RDS: implement CopyTags and Tags parameters for copy_db_snapshot()

moto/rds/models.py

@@ -1838,15 +1838,19 @@ def copy_db_snapshot(
         source_snapshot_identifier: str,
         target_snapshot_identifier: str,
         tags: Optional[List[Dict[str, str]]] = None,
+        copy_tags: bool = False,
     ) -> DBSnapshot:
         if source_snapshot_identifier not in self.database_snapshots:
             raise DBSnapshotNotFoundError(source_snapshot_identifier)
 
         source_snapshot = self.database_snapshots[source_snapshot_identifier]
-        if tags is None:
-            tags = source_snapshot.tags
-        else:
-            tags = self._merge_tags(source_snapshot.tags, tags)
+
+        # When tags are passed, AWS does NOT copy/merge tags of the
+        # source snapshot, even when copy_tags=True is given.
+        # But when tags=[], AWS does honor copy_tags=True.
+        if not tags:
+            tags = source_snapshot.tags if copy_tags else []
+
         return self.create_db_snapshot(
             db_instance=source_snapshot.database,
             db_snapshot_identifier=target_snapshot_identifier,

moto/rds/responses.py

@@ -303,8 +303,9 @@ def copy_db_snapshot(self) -> str:
         source_snapshot_identifier = self._get_param("SourceDBSnapshotIdentifier")
         target_snapshot_identifier = self._get_param("TargetDBSnapshotIdentifier")
         tags = self.unpack_list_params("Tags", "Tag")
+        copy_tags = self._get_param("CopyTags")
         snapshot = self.backend.copy_db_snapshot(
-            source_snapshot_identifier, target_snapshot_identifier, tags
+            source_snapshot_identifier, target_snapshot_identifier, tags, copy_tags
         )
         template = self.response_template(COPY_SNAPSHOT_TEMPLATE)
         return template.render(snapshot=snapshot)

tests/test_rds/test_rds.py

@@ -1076,6 +1076,48 @@ def test_copy_db_snapshots(delete_db_instance: bool):
     assert result["TagList"] == []
 
 
+@mock_aws
+def test_copy_db_snapshots_copytags_and_tags():
+    conn = boto3.client("rds", region_name=DEFAULT_REGION)
+    conn.create_db_instance(
+        DBInstanceIdentifier="db-primary-1",
+        Engine="postgres",
+        DBInstanceClass="db.m1.small",
+    )
+
+    original_tags = [{"Key": "original", "Value": "snapshot tags"}]
+    conn.create_db_snapshot(
+        DBInstanceIdentifier="db-primary-1",
+        DBSnapshotIdentifier="snapshot",
+        Tags=original_tags,
+    )
+
+    new_tags = [{"Key": "new", "Value": "tag"}]
+    kwargs_and_expected_results = [
+        # No Tags parameter, CopyTags defaults to False -> no tags
+        ({}, []),
+        # No Tags parameter, CopyTags set to True -> use tags of original snapshot
+        ({"CopyTags": True}, original_tags),
+        # When "Tags" are given, they become the only tags of the snapshot.
+        ({"Tags": new_tags}, new_tags),
+        # When "Tags" are given, they become the only tags of the snapshot. Even if CopyTags is True!
+        ({"Tags": new_tags, "CopyTags": True}, new_tags),
+        # When "Tags" are given but empty, CopyTags=True takes effect again!
+        ({"Tags": [], "CopyTags": True}, original_tags),
+    ]
+    for kwargs, expected_result in kwargs_and_expected_results:
+        target_snapshot = conn.copy_db_snapshot(
+            SourceDBSnapshotIdentifier="snapshot",
+            TargetDBSnapshotIdentifier="snapshot-copy",
+            **kwargs,
+        ).get("DBSnapshot")
+        result = conn.list_tags_for_resource(
+            ResourceName=target_snapshot["DBSnapshotArn"]
+        )
+        assert result["TagList"] == expected_result
+        conn.delete_db_snapshot(DBSnapshotIdentifier="snapshot-copy")
+
+
 @mock_aws
 def test_describe_db_snapshots():
     conn = boto3.client("rds", region_name=DEFAULT_REGION)