Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Remove univeral wheel option #8299

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

bblommers
Copy link
Collaborator

Universal wheels were a great way to indicate that a project supported both Python 2 and 3.. but it's probably time to get rid of that.

That should also get rid of a deprecation warning when building the project:

2024-11-08T19:59:54.2032474Z /tmp/.../setuptools/_distutils/cmd.py:111: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
2024-11-08T19:59:54.2034257Z !!
2024-11-08T19:59:54.2034534Z 
2024-11-08T19:59:54.2037019Z         ********************************************************************************
2024-11-08T19:59:54.2038500Z         With Python 2.7 end-of-life, support for building universal wheels
2024-11-08T19:59:54.2039705Z         (i.e., wheels that support both Python 2 and Python 3)
2024-11-08T19:59:54.2040740Z         is being obviated.
2024-11-08T19:59:54.2041664Z         Please discontinue using this option, or if you still need it,
2024-11-08T19:59:54.2042873Z         file an issue with pypa/setuptools describing your use case.
2024-11-08T19:59:54.2043571Z 
2024-11-08T19:59:54.2044461Z         By 2025-Aug-30, you need to update your project and remove deprecated calls
2024-11-08T19:59:54.2045657Z         or your builds will no longer be supported.
2024-11-08T19:59:54.2046985Z         ********************************************************************************
2024-11-08T19:59:54.2047609Z 
2024-11-08T19:59:54.2048023Z !!

@bblommers bblommers added this to the 5.0.21 milestone Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (60828f4) to head (ab85adb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8299      +/-   ##
==========================================
- Coverage   94.57%   94.56%   -0.01%     
==========================================
  Files        1158     1158              
  Lines      100841   100841              
==========================================
- Hits        95366    95363       -3     
- Misses       5475     5478       +3     
Flag Coverage Δ
servertests 28.87% <ø> (ø)
unittests 94.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit cdc4bab into getmoto:master Nov 8, 2024
52 of 53 checks passed
@bblommers bblommers deleted the admin-remove-universal-wheel branch November 8, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant