DynamoDB: table exports #7839
DynamoDB: table exports #7839
Conversation
| backup.append(json_item) | ||
| self.processed_bytes += len(json_item) | ||
| self.item_count = len(backup) | ||
| content = gzip_compress(json.dumps(backup).encode("utf-8")) |
There was a problem hiding this comment.
this doesn't exactly match the way aws does the export - is this important?
| self.s3_prefix = s3_prefix | ||
| self.status = "IN_PROGRESS" | ||
| self.export_format = export_format | ||
| self.export_type = export_type |
There was a problem hiding this comment.
I haven't built anything for incremental export, is what is exported important here? I'm not even sure how we would go about supporting incremental exports as we'd need to be taking snapshots of the table and everything's stored in memory so I've just left it to perform the same as the full export.
|
@bblommers anything i can do to speed up this being merged? |
|
@bblommers the tests should be fixed now |
|
@rita-cheung Looks like the linter is failing. Make sure to run |
|
@bpandola fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7839 +/- ##
==========================================
+ Coverage 94.34% 94.36% +0.01%
==========================================
Files 1107 1114 +7
Lines 93980 94968 +988
==========================================
+ Hits 88665 89613 +948
- Misses 5315 5355 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@bpandola I added some tests to improve code coverage |
|
@rita-cheung Thank you for this high-quality contribution to |
|
This is now part of moto >= 5.0.12.dev42 |
Implemented 3 dynamodb functions: