Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to set a site-wide password #7

Closed
queicherius opened this issue Dec 12, 2020 · 4 comments
Closed

Add the ability to set a site-wide password #7

queicherius opened this issue Dec 12, 2020 · 4 comments
Assignees
@gempain
Labels
feature New feature
Milestone
v1.0.0-beta.5

Comments

@queicherius
Copy link

I would like to set a password on a site basis, so it gets automatically applied to all branches that get uploaded.

The use-case here is an internal documentation I would like to deploy once for master, and then automatically for each pull request - but all branches have to be protected.

An alternative would be the ability to set the password via the CLI tool during upload.
@gempain
Copy link
Contributor

gempain commented Dec 13, 2020

Hi @queicherius, and thanks for open an issue here. It's a great idea, and I'll add this to the next release.

An alternative would be the ability to set the password via the CLI tool during upload.

It makes sense, but in the context of CI, I think this would be difficult to use unless you have a manual job for setting it. I'd like to keep the CLI dedicated to uploading releases at the moment, but I'll keep this in mind anyway.

I'll work on this and add it to the next release.

@gempain gempain added the feature New feature label Dec 13, 2020
@gempain gempain added this to the v1.0.0-beta.5 milestone Dec 13, 2020
@gempain gempain self-assigned this Dec 13, 2020
gempain pushed a commit that referenced this issue Dec 14, 2020
feat: site wide password (#7)
b08fdac
gempain pushed a commit that referenced this issue Dec 14, 2020
@semantic-release-bot
chore(release): 1.0.0-beta.5 [skip ci]
ef2ef9c 
# [1.0.0-beta.5](v1.0.0-beta.4...v1.0.0-beta.5) (2020-12-14)

### Bug Fixes

* improve ssl support ([8e8778e](8e8778e))
* migrations directory is reuqired ([#4](#4)) ([b6c0778](b6c0778))
* password protection conflicts with route matching ([3cc960f](3cc960f))
* setting branch password crashes meli ([#6](#6)) ([513c7df](513c7df))
* site 404 not matched ([249fbd5](249fbd5))
* ssl support for auto domains ([12cf89f](12cf89f))
* **unified:** entrypoint not executable ([1196e5a](1196e5a))
* uniffied docker image extends outdated UI image ([0532af2](0532af2))

### chore

* remove MELI_BCRYPT_SALTROUNDS env var ([04eaec0](04eaec0))

### Features

* add var for api path ([fdb8eed](fdb8eed))
* handle static response for 404 and 523 in caddy ([abd1272](abd1272))
* rollback adding api path ([61aab54](61aab54))
* site wide password ([#7](#7)) ([b08fdac](b08fdac))
* spa mode ([#5](#5)) ([79c2cce](79c2cce))

### Performance Improvements

* enhance dockerfile caching ([34a3fd2](34a3fd2))

### BREAKING CHANGES

* MELI_BCRYPT_SALTROUNDS was removed
@gempain
Copy link
Contributor

gempain commented Dec 14, 2020 •
edited

@queicherius this fix was released in v1.0.0-beta.5. A toggle is now available in your site settings. It's the same toggle and behavior as for site branches. I'm closing, but you may continue to reply if further help is required. We'll reopen if needed. Again, many thanks for contributing to this project.

Note that if you set a site-wide password and then a branch password, the branch password will override the site's password.

@gempain gempain closed this as completed Dec 14, 2020
@queicherius
Copy link
Author

Awesome, thank you so much!

@gempain
Copy link
Contributor

gempain commented Dec 14, 2020 •
edited

Very welcome 🙇‍♀️

cooldev330 added a commit to cooldev330/Deploy-app that referenced this issue Aug 4, 2024
@cooldev330
chore(release): 1.0.0-beta.5 [skip ci]
5f3f134 
# [1.0.0-beta.5](getmeli/meli@v1.0.0-beta.4...v1.0.0-beta.5) (2020-12-14)

### Bug Fixes

* improve ssl support ([8e8778e](getmeli/meli@8e8778e))
* migrations directory is reuqired ([#4](getmeli/meli#4)) ([b6c0778](getmeli/meli@b6c0778))
* password protection conflicts with route matching ([3cc960f](getmeli/meli@3cc960f))
* setting branch password crashes meli ([#6](getmeli/meli#6)) ([513c7df](getmeli/meli@513c7df))
* site 404 not matched ([249fbd5](getmeli/meli@249fbd5))
* ssl support for auto domains ([12cf89f](getmeli/meli@12cf89f))
* **unified:** entrypoint not executable ([1196e5a](getmeli/meli@1196e5a))
* uniffied docker image extends outdated UI image ([0532af2](getmeli/meli@0532af2))

### chore

* remove MELI_BCRYPT_SALTROUNDS env var ([04eaec0](getmeli/meli@04eaec0))

### Features

* add var for api path ([fdb8eed](getmeli/meli@fdb8eed))
* handle static response for 404 and 523 in caddy ([abd1272](getmeli/meli@abd1272))
* rollback adding api path ([61aab54](getmeli/meli@61aab54))
* site wide password ([#7](getmeli/meli#7)) ([b08fdac](getmeli/meli@b08fdac))
* spa mode ([#5](getmeli/meli#5)) ([79c2cce](getmeli/meli@79c2cce))

### Performance Improvements

* enhance dockerfile caching ([34a3fd2](getmeli/meli@34a3fd2))

### BREAKING CHANGES

* MELI_BCRYPT_SALTROUNDS was removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gempain gempain

Labels
feature New feature
Projects
None yet
Milestone
v1.0.0-beta.5
Development

No branches or pull requests
2 participants
@queicherius @gempain