-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploaded images not found #230
Comments
Images are stored in |
After mounting a local directory into the container (and before doing this) I can't delete or upload a new logo. If I try to delete the existing (broken) image I get a 500 error and this message:
Trying to upload a new one also results in a similar 500 error with:
|
I see the issue. It's because we're trying to delete the logo while it doesn't exist. Sorry for the inconvenience. Will com up with a fix. |
No problem and thanks as always for your quick response! |
# [1.0.0-beta.23](v1.0.0-beta.22...v1.0.0-beta.23) (2021-05-21) ### Bug Fixes * cannot upload or delete logo (closes [#230](#230)) ([970e1f4](970e1f4)) * incorrect description and missing info in package.json ([#227](#227)) ([290de80](290de80)) * wrong site / branch url in ui ([d33f03f](d33f03f)) ### Features * allow deleting branches with site token ([b107ed7](b107ed7)) * update DomainForm with private key help text ([#231](#231)) ([da4562d](da4562d)) * upload release with api token ([#216](#216)) ([#225](#225)) ([1d5ceb6](1d5ceb6))
🎉 This issue has been resolved in version 1.0.0-beta.23 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks! Although for some reason I can't upload images on this new release. Deleting the broken image worked fine though. Uploading throws a 500 error. I've got a mount in my docker-compose file:
I can touch a file in Do want a new issue for this? |
Are you sure you're using the latest version ? I just tried on our environment and it seems to work fine. Did you |
I did yes, but I was on the |
Meli is showing {
"ui": {
"version": "1.0.0-beta.13",
"commitHash": "2021-05-21T12:41:58.366Z",
"buildDate": "2021-05-21T12:41:58.366Z"
},
"api": {
"version": "1.0.0-beta.23",
"buildDate": "2021-05-21T12:41:44.941Z",
"commitHash": "970e1f4d5fda64545a95b36028f11c35be90bf7a"
}
} I've tried making the |
I just disabled the files volume mount and re-upped the containers and the uploading of images works. So something isn't good with my mount |
The docker logs show this when trying to upload a file with a volume mount:
|
Looks like a limit of rename, suggestions I've read are to copy the file into place first and then delete the version in |
Ohhhh yes, I see, we've had this problem before for uploading sites and fixed it by copying. It's a problem related to how Docker works. We're first uploading the image into a temporary directory which isn't mapped, and then moving it to |
@tanc this was an easy fix, sorry for the delay 😄 I'll release on beta soon. |
@tanc this should be fixed in beta 24. I'll close, but we can reopen if needed. |
# [1.0.0-beta.23](getmeli/meli@v1.0.0-beta.22...v1.0.0-beta.23) (2021-05-21) ### Bug Fixes * cannot upload or delete logo (closes [#230](getmeli/meli#230)) ([970e1f4](getmeli/meli@970e1f4)) * incorrect description and missing info in package.json ([#227](getmeli/meli#227)) ([290de80](getmeli/meli@290de80)) * wrong site / branch url in ui ([d33f03f](getmeli/meli@d33f03f)) ### Features * allow deleting branches with site token ([b107ed7](getmeli/meli@b107ed7)) * update DomainForm with private key help text ([#231](getmeli/meli#231)) ([da4562d](getmeli/meli@da4562d)) * upload release with api token ([#216](getmeli/meli#216)) ([#225](getmeli/meli#225)) ([1d5ceb6](getmeli/meli@1d5ceb6))
# [1.0.0-beta.24](getmeli/meli@v1.0.0-beta.23...v1.0.0-beta.24) (2021-05-25) ### Bug Fixes * cannot upload logo [#230](getmeli/meli#230) ([3181cab](getmeli/meli@3181cab)) * **security:** update lodash ([12e4dc3](getmeli/meli@12e4dc3))
I wanted to modify the email environment variables passed into the docker images so I issued a
docker-compose down
anddocker-compose up -d
. Once it came up successfully I noticed the image I had uploaded for one site won't load. Are these stored somewhere in the docker image rather than in the database or a non-volatile volume or filesystem?The server issues a 404 for that image:
Resulting in a broken image link and the alt text "bubble" being shown:
Might also be worth changing the alt text to an empty string to indicate the image is purely decorative.
The text was updated successfully, but these errors were encountered: