-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: improve pagination and scraping logic #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Interpreter
participant Scraper
Caller->>Interpreter: call handlePagination()
alt Pagination Successful
Interpreter-->>Caller: return paginated results
else Pagination Fails & Max Retries Reached
Interpreter->>Scraper: scrapeCurrentPage()
Scraper-->>Interpreter: return scraped data
Interpreter-->>Caller: return accumulated results
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR focuses on improving the pagination logic and core scraping logic of Maxun.
Summary by CodeRabbit