Skip to content

fix: improve list container detection and highlighting #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amhsirak merged 1 commit into from
Mar 21, 2025
+54 −3
Merged

fix: improve list container detection and highlighting #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 54 additions & 3 deletions server/src/workflow-management/selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,24 @@ export const getElementInformation = async (
return deepestElement;
};

let deepestElement = findDeepestElement(elements);
// Logic to get list container element
let targetElement = null;

for (const element of elements) {
const deepestEl = findDeepestElement(elements);

if (deepestEl && element !== deepestEl) {
if (element.contains(deepestEl) &&
element !== deepestEl.parentElement &&
element.tagName !== 'HTML' &&
element.tagName !== 'BODY') {
targetElement = element;
break;
}
}
}

let deepestElement = targetElement || findDeepestElement(elements);
if (!deepestElement) return null;

const traverseShadowDOM = (element: HTMLElement): HTMLElement => {
Expand Down Expand Up @@ -854,7 +871,24 @@ export const getRect = async (page: Page, coordinates: Coordinates, listSelector
return deepestElement;
};

let deepestElement = findDeepestElement(elements);
// Logic to get list container element
let targetElement = null;

for (const element of elements) {
const deepestEl = findDeepestElement(elements);

if (deepestEl && element !== deepestEl) {
if (element.contains(deepestEl) &&
element !== deepestEl.parentElement &&
element.tagName !== 'HTML' &&
element.tagName !== 'BODY') {
targetElement = element;
break;
}
}
}

let deepestElement = targetElement || findDeepestElement(elements);
if (!deepestElement) return null;

const traverseShadowDOM = (element: HTMLElement): HTMLElement => {
Expand Down Expand Up @@ -2036,7 +2070,24 @@ export const getNonUniqueSelectors = async (page: Page, coordinates: Coordinates
return deepestElement;
};

let deepestElement = findDeepestElement(elements);
// Logic to get list container element
let targetElement = null;

for (const element of elements) {
const deepestEl = findDeepestElement(elements);

if (deepestEl && element !== deepestEl) {
if (element.contains(deepestEl) &&
element !== deepestEl.parentElement &&
element.tagName !== 'HTML' &&
element.tagName !== 'BODY') {
targetElement = element;
break;
}
}
}

let deepestElement = targetElement || findDeepestElement(elements);
Comment on lines +2073 to +2090
Copy link

@coderabbitai coderabbitai bot Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Same inefficiency in the third occurrence

This is the third instance of the same inefficient pattern where findDeepestElement(elements) is repeatedly called inside the loop.

Since this pattern is repeated in three places, consider creating a helper function that implements this list container detection logic efficiently, which can then be reused in all three locations:

function findTargetElementOrDeepest(elements) {
  const deepestEl = findDeepestElement(elements);
  if (!deepestEl) return null;
  
  let targetElement = null;
  for (const element of elements) {
    if (element !== deepestEl && 
        element.contains(deepestEl) && 
        element !== deepestEl.parentElement && 
        element.tagName !== 'HTML' && 
        element.tagName !== 'BODY') {
      targetElement = element;
      break;
    }
  }
  
  return targetElement || deepestEl;
}

This would improve both performance and maintainability by eliminating duplicated code.

if (!deepestElement) return null;

const traverseShadowDOM = (element: HTMLElement): HTMLElement => {
Expand Down