Skip to content

fix: attribute selection on link selections #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amhsirak merged 1 commit into from
Mar 19, 2025
Merged

fix: attribute selection on link selections #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions server/src/workflow-management/selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,8 @@ export const getElementInformation = async (

if (el) {
// Prioritize Link (DO NOT REMOVE)
// const { parentElement } = el;
// const targetElement = parentElement?.tagName === 'A' ? parentElement : el;

const targetElement = el;
const { parentElement } = el;
const targetElement = parentElement?.tagName === 'A' ? parentElement : el;

const ownerDocument = targetElement.ownerDocument;
const frameElement = ownerDocument?.defaultView?.frameElement as HTMLIFrameElement;
Expand Down Expand Up @@ -705,10 +703,9 @@ export const getRect = async (page: Page, coordinates: Coordinates, listSelector
const el = getDeepestElementFromPoint(x, y);
if (el) {
// Prioritize Link (DO NOT REMOVE)
// const { parentElement } = el;
// const element = parentElement?.tagName === 'A' ? parentElement : el;
const { parentElement } = el;
const element = parentElement?.tagName === 'A' ? parentElement : el;

const element = el;
const rectangle = element?.getBoundingClientRect();
if (rectangle) {
const createRectObject = (rect: DOMRect) => ({
Expand Down Expand Up @@ -1882,11 +1879,10 @@ export const getSelectors = async (page: Page, coordinates: Coordinates) => {
!hoveredElement.closest('#overlay-controls') != null
) {
// Prioritize Link (DO NOT REMOVE)
// const { parentElement } = hoveredElement;
const { parentElement } = hoveredElement;
// Match the logic in recorder.ts for link clicks
// const element = parentElement?.tagName === 'A' ? parentElement : hoveredElement;
const element = parentElement?.tagName === 'A' ? parentElement : hoveredElement;

const element = hoveredElement;
const generatedSelectors = genSelectors(element);
return generatedSelectors;
}
Expand Down