Revert "fix: prevent page reload on run trigger to open remote browser"

[amhsirak]

Reverts #386

Summary by CodeRabbit

• Refactor

  • Simplified browser management by removing robot run state tracking
  • Removed socket emission for run completion
  • Cleaned up recording and interpretation handling logic
  • Renamed method to follow camelCase convention

• Bug Fixes

  • Removed unnecessary checks and middleware related to robot run states

• Chores

  • Streamlined code by eliminating redundant state management and socket communication

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves a comprehensive refactoring of browser and workflow management components across multiple files. The changes primarily focus on removing the isRobotRun property and associated logic from the BrowserPool class, simplifying method signatures, and eliminating socket-based run completion notifications. The modifications streamline the browser management and interpretation processes by removing conditional checks and notification mechanisms related to robot runs and run completion states.

Changes

File	Change Summary
server/src/browser-management/classes/BrowserPool.ts	Removed isRobotRun property from BrowserPoolInfo interface, simplified addRemoteBrowser method signature, deleted hasActiveRobotRun and clearRobotRunState methods
server/src/browser-management/controller.ts	Updated createRemoteBrowserForRun to remove fourth argument in browserPool.addRemoteBrowser call
server/src/routes/record.ts	Removed middleware for checking active robot runs and related import
server/src/workflow-management/classes/Interpreter.ts	Removed socket emission for 'run-completed' event, renamed InterpretRecording to interpretRecording
src/pages/MainPage.tsx	Reinstated interpretation result notifications, removed run completion socket listener and local storage management

Possibly related PRs

• fix: prevent page reload on run trigger to open remote browser #386: Introduced isRobotRun property to BrowserPoolInfo interface, which is now being removed in this PR

Suggested labels

Type: Chore

Poem

🐰 A Rabbit's Refactor Tale 🐰

Bits and bytes, now clean and light,
Robot runs fade from coding's sight
Methods trimmed with careful grace
Simplicity now takes its place
Code hops free, no burden's might!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85b4786 and 153cf81.

📒 Files selected for processing (5)

• server/src/browser-management/classes/BrowserPool.ts (1 hunks)
• server/src/browser-management/controller.ts (1 hunks)
• server/src/routes/record.ts (0 hunks)
• server/src/workflow-management/classes/Interpreter.ts (0 hunks)
• src/pages/MainPage.tsx (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.