Skip to content

fix: translation changes #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2025
Merged

fix: translation changes #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35a44bb
fix: rm translation for alt maxun_logo
RohitR311 Jan 3, 2025
1874e71
fix: add translation for same name robot creation
RohitR311 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/molecules/ActionDescriptionBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ const ActionDescriptionBox = () => {

return (
<CustomBoxContainer>
<Logo src={MaxunLogo} alt={t('common.maxun_logo')} />
<Logo src={MaxunLogo} alt='maxun_logo' />
<Triangle />
<Content>
{renderActionDescription()}
Expand Down
2 changes: 1 addition & 1 deletion src/components/molecules/SaveRecording.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const SaveRecording = ({ fileName }: SaveRecordingProps) => {
</Button>
<WarningText>
<NotificationImportantIcon color="warning" />
{t('save_recording.warnings.robot_exists')}
{t('save_recording.errors.exists_warning')}
Copy link

@coderabbitai coderabbitai bot Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing translation key detected

The translation key save_recording.errors.exists_warning is used in SaveRecording.tsx but could not be found in any translation files. This may lead to missing translation errors in the UI. Please:

  • Add the translation key to all language files (en.json, es.json, ja.json, zh.json, de.json) in the public/locales directory
  • Ensure the translation text is appropriate for warning users about existing recordings
🔗 Analysis chain

Ensure the new translation key exists and is correct.

You changed the key to t('save_recording.errors.exists_warning'). Verify that this key is present and properly translated in your i18n files. Otherwise, the UI may show a missing translation error.

Use the following script to search for the key in your translation resources:

Let me search for the translation key in the localization files.

Let me try to find translation files in other common locations.

Let me try one more search to find any translation-related files and their structure.

Let me check the public directory for translation files since the loadPath shows '/locales/{{lng}}.json'.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for the 'save_recording.errors.exists_warning' key in translation files.
rg -A 3 "save_recording.errors.exists_warning"

Length of output: 422

Script:

#!/bin/bash
# Search for translation files and then look for the key
fd -e json -e yaml -e yml . src/locales/ --exec rg -l "save_recording.errors.exists_warning" {}

Length of output: 197

Script:

#!/bin/bash
# Find all json/yaml/yml files in the repository and search for the translation key
fd -e json -e yaml -e yml . --exec rg -l "save_recording.errors.exists_warning" {}

Length of output: 84

Script:

#!/bin/bash
# Find translation files and their structure
fd -t f "translation|i18n|locale" --exec head -n 20 {}

Length of output: 580

Script:

#!/bin/bash
# Check public directory for translation files
fd -e json . public/locales --exec rg "save_recording.errors.exists_warning" {}

Length of output: 81

</WarningText>
</React.Fragment>)
: <Button type="submit" variant="contained" sx={{ marginTop: '10px' }}>
Expand Down