Feature/adjustable page gaps #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkalexling
reviewed
Jan 6, 2021
|
Thanks a lot for the PR! It looks pretty good overall. I left a comment, and it would be great if you could revise a bit! |
hkalexling
approved these changes
Jan 6, 2021
|
Great! Thanks for contributing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
As I was a little annoyed by the gaps between pages, even when seleting the 'continuous' mode, I decided to make the gaps adjustable. You can now specify the gap size in px by adding the entry 'page_margin' to the config file. By setting the size to '0', you have no gaps at all.
Thank you for this great software!
I created a new pull request and deleted the old one because I didn't read the development guideline first 🤦♂️