Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add webp image support #69

Closed
ghost opened this issue Jun 13, 2020 · 3 comments
Closed

[Feature Request] Add webp image support #69

ghost opened this issue Jun 13, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jun 13, 2020

Is your feature request related to a problem? Please describe.
Currently only PNG and JPEG is supported, but new formats like WEBP gives you impressive space saving results when used on manga images, so i would like to see added support for it.
On my personal library i found over 50% less space was used.
I found even more impressive results with HEIC, but no browser supports it, so we'd need to supply a client sided converter for it, which is cumbersome.

@ghost ghost added the enhancement New feature or request label Jun 13, 2020
@ghost ghost changed the title [Feature Request] Add webp support [Feature Request] Add webp image support Jun 13, 2020
@hkalexling
Copy link
Member

Supporting webp is a good idea. I will include this in the next version.

For HEIC (and other currently unsupported filetypes), we could use something like libvips to convert the images to jpeg on the fly before serving them. I don't think HEIC support should be prioritized at this stage as it's rare to find archives containing HEIC images, but PRs are always welcome.

hkalexling added a commit that referenced this issue Jun 15, 2020
@ghost
Copy link
Author

ghost commented Jun 19, 2020

I see commit dc084af where you added webp support and am closing the issue.

@ghost ghost closed this as completed Jun 19, 2020
@hkalexling
Copy link
Member

This feature is now available in v0.7.0. Thanks for the request!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant