Offer a longer trial for filling out a short survey #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the stage to add time to the trial for filling out the survey.
kienstra
changed the title
Also, remove await before showLicenseInput().
Before, there was an error when the button wasn't in the DOM.
Otherwise, 17 days immediately goes down to 16 days, as it's Math.floor().
It's confusing when it says there's a 2-day trial, but it shows 1 day, 23 hours.
kienstra
commented
Dec 2, 2021
| @@ -255,6 +258,4 @@ export function activate(context: vscode.ExtensionContext): void { | |||
| } | |||
| }, | |||
| }); | |||
|
|
|||
| getLicenseInformation(context); | |||
There was a problem hiding this comment.
This was hacky, it's replaced with the globalState.update() above
This shouldn't be a decimal like 1.4232 hours.
Its closing tag should be a </a>, not a </button>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes