Email 1 - Address class
#6629
Closed
Email 1 - Address class
#6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
v5/email/1-address-class
branch
from
9b3d587
to
245b6a0
Compare
9 tasks
distantnative
force-pushed
the
v5/email/1-address-class
branch
from
245b6a0
to
097634d
Compare
This was referenced Aug 18, 2024
afbora
reviewed
Aug 19, 2024
| * Returns one or multiple addresses as array | ||
| * where the emails are the keys and the names the values | ||
| */ | ||
| public static function resolve(array|Address $address): array |
There was a problem hiding this comment.
I think array usage that doesn't includes Address object is invalid:
// single
Address::resolve(['[email protected]']);
// multiple
Address::resolve([
'[email protected]' => null,
'[email protected]' => 'Lisa Simpson'
]);If array items are should to be Address objects, it would be nice to have a type check.
There was a problem hiding this comment.
I'll make the method description more explicit. It is only meant to resolve Address objects and arrays of Address objects. There should be no need to support other formats.
There was a problem hiding this comment.
Conversation is resolved but I couldn't see any changes?
|
Closing this for a moment, so we can better focus on some bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Email\Addressclass that handles all address parsing and resolving for from, to, bcc, cc, replyTo::clone()methodReasoning
Changelog
Removed deprecated code
Email\Email::clone()Ready?
For review team