openapi3: Implement YAML Marshaler interface for AdditionalProperties #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this bug when serializing an OpenAPI spec with component schemas that had
additionalProperties. Once marshaled, the schema would end up with the rawhasandschemaproperties of theAdditionalPropertiesstruct type and thereafter it's impossible to have a successfully validating OpenAPI doc loaded from that modified schema. I've also added a test to describe the issue.I've also run
./docs.shand committed the diff as a separate commit. Please let me know if you have any questions.