Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi3: add support for UUID v6-8 #750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexg-axis
Copy link

The current UUID format regex matches UUID version 1-5 in accordance to
the current RFC 4122.

There's a draft to update the spec, which adds three new versions. The
intention of this PR is to add support for these versions.

See: https://datatracker.ietf.org/doc/html/draft-ietf-uuidrev-rfc4122bis-01.

@alexg-axis
Copy link
Author

I didn't find any reference stating that OpenAPI strictly supports UUID v1-5, hence I though it would be in scope to add support here directly.

@fenollp
Copy link
Collaborator

fenollp commented Jan 24, 2023

Well this isn't the same RFC so I'm more encline to not update this var but instead to add a new one with the bis01 name. Is that fine with you?

@alexg-axis
Copy link
Author

Well this isn't the same RFC so I'm more encline to not update this var but instead to add a new one with the bis01 name. Is that fine with you?

Do you still think that the uuid format should use the new bis01 name? If so, what would be the use of keeping the current var as well?

@zekth
Copy link
Contributor

zekth commented Mar 26, 2023

Well this isn't the same RFC so I'm more encline to not update this var but instead to add a new one with the bis01 name. Is that fine with you?

Do you still think that the uuid format should use the new bis01 name? If so, what would be the use of keeping the current var as well?

I think we might want to keep both esp is the consumer app have to support v1-5 and not v8. Eg: v8 has introduced uuid.Max also which is not supported in other implementations.

@fenollp
Copy link
Collaborator

fenollp commented May 13, 2023

Please, don't modify current behavior. Add a second var with bis01 suffix and test behavior (covered, not covered, covered by both).

@fenollp fenollp changed the title Add support for UUID v6-8 openapi3: add support for UUID v6-8 May 13, 2023
@fenollp
Copy link
Collaborator

fenollp commented Jun 18, 2023

@alexg-axis Hey there. Do you need help moving this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants