WIP: Use santhosh-tekuri/jsonschema #487
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based of this PR #318 to remove internal validation and originally replace with xeipuuv/gojsonschema and then in the newest commits replace with santhosh-tekuri/jsonschema
I'm using an extension (openapi3/components_extension.go to validate all
components.schemas
in one go as this seems to be the only way to keep internal document referencing working, e.g.#/components.schemas.ExampleObject
.This is very much still a work in progress and I'd need to resolve the fact the for this to work fully within the openapi3filter we'll need the complete
openapi3.T
document to resolve request and response references too. However, that very much seems to go against the grain of the current design.I could use some input or opinions on direction. @fenollp