Enhancement: add label formatting for dynamic-list customapi widget#5217
Merged
shamoon merged 1 commit intoApr 25, 2025
Merged
Conversation
- make use of the `formatValue` function for formatting the label in dynamic lists - the `format` parameter is at the same level as the `label` parameter to keep it consistent with other display views
shamoon
approved these changes
Apr 25, 2025
Collaborator
shamoon
left a comment
There was a problem hiding this comment.
Thanks
ps. Technically this supports other things too now besides format…
Contributor
Author
|
Indeed, I admit I could have been a bit more thorough with it. It should enable support for |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds the capability to format the label in dynamic-list for the customapi widget. The options are the ones already available :
text,number,float,percent,duration,bytes,bitrate,size,dateandrelativeDate.There wasn't an open specific feature request for this but I figured I must not be the only one who wants this since I noticed interest in comments of this one : #4906 (comment).
I was going to make it for myself anyways so I thought I might as well share it. I know it isn't technically allowed in the guidelines to not have a linked feature request, so feel free to reject this PR for this reason.
I chose to parse the
formatparameter at the same level aslabelto keep it consistent with the rest of the display config options.Type of change
Checklist: