Skip to content

Fix: Longhorn still showing Total despite total: false#5200

Merged
shamoon merged 1 commit into
gethomepage:devfrom
kevinastone:patch-1
Apr 21, 2025
Merged

Fix: Longhorn still showing Total despite total: false#5200
shamoon merged 1 commit into
gethomepage:devfrom
kevinastone:patch-1

Conversation

@kevinastone
Copy link
Copy Markdown
Contributor

@kevinastone kevinastone commented Apr 20, 2025

The logic was falling to the final return true rather than breaking the logic chain when the node.id was matched to "total" and return false.

Proposed change

Fixes where the widgets.yaml configuration includes:

- longhorn:
    total: false
    nodes: true

Still shows a total node.

Type of change

Bug-fix

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

The logic was falling to the final `return true` rather than breaking the logic chain when the node.id was matched to `"total"` and return false.
@shamoon shamoon changed the title Fix Longhorn still showing Total despite total: false Fix: Longhorn still showing Total despite total: false Apr 21, 2025
@shamoon shamoon enabled auto-merge (squash) April 21, 2025 00:39
Copy link
Copy Markdown
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks

@shamoon shamoon merged commit 1fe4f49 into gethomepage:dev Apr 21, 2025
2 checks passed
@kevinastone kevinastone deleted the patch-1 branch April 21, 2025 01:20
tombatossals pushed a commit to tombatossals/homepage that referenced this pull request Apr 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants