Chore: add more Docker Semver Tags#5107
Merged
Merged
Conversation
shamoon
reviewed
Mar 31, 2025
shamoon
approved these changes
Mar 31, 2025
Collaborator
shamoon
left a comment
There was a problem hiding this comment.
Thanks. Always a bit of a trial-and-error about GHA stuff, hope this works :)
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This is a GH workflow change to add proper semantic versioning tags to the Docker build & push step.
Reasoning for the multiple tags is explained in this old Medium article.
After the recent breaking changes with the major version bump it became apparent that auto updating to the
latesttag was not ideal, but manually updating after each patch release requires to much human input. Having SemVer Docker tags with multiple levels users can pin their config to has become common practice for many popular self-hosted docker services.I hope that this PR will bring this practice to
homepageas well.Type of change
PR is not related to the functionality of the application itself, but the way it is built / distributed.
Checklist:
Note
None of these check are really applicable to the changes in this PR.
However I have tested the functionality in a test CI/CD run. See
Extract Docker metadatastep,docker tagssub menu.