Skip to content

Enhancement: Add support for specifying a datastore to PBS widget#4614

Merged
shamoon merged 6 commits into
gethomepage:devfrom
choehn86:dev
Apr 28, 2025
Merged

Enhancement: Add support for specifying a datastore to PBS widget#4614
shamoon merged 6 commits into
gethomepage:devfrom
choehn86:dev

Conversation

@choehn86
Copy link
Copy Markdown
Contributor

Proposed change

Implements changes to accommodate this feature request.

PBS datastore configuration:
PBS

Example services.yaml specifying 'local-backups' datastore:

- Proxmox Backup Server:
    href: https://pbs.domain
    description: Proxmox Backup Server
    widget:
      type: proxmoxbackupserver
      url: https://pbs.domain
      username: homepage@pbs!api
      password: apikey
      datastore: "local-backups"

Result:

Widget-local-backups

Example services.yaml without datastore key:

- Proxmox Backup Server:
    href: https://pbs.domain
    description: Proxmox Backup Server
    widget:
      type: proxmoxbackupserver
      url: https://pbs.domain
      username: homepage@pbs!api
      password: apikey

Result is the combination of all datastores used / total:

Widget-all

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Changed to accommodate multiple datastores or a specific datastore supplied in services.yaml
Implemented datastore key for proxmoxbackupserver widget
@shamoon
Copy link
Copy Markdown
Collaborator

shamoon commented Jan 16, 2025

There are 2 votes on that FR, you and the other user. Let's make sure theres a bit more interest before reviewing this. We can readdress in the future, thanks

@shamoon shamoon closed this Jan 16, 2025
@choehn86
Copy link
Copy Markdown
Contributor Author

choehn86 commented Jan 17, 2025

@shamoon Is it worth taking a second look from a bug-fix perspective? Today anyone using the widget who has >1 datastore will get inconsistent monitoring due to the widget being hard-coded to always look at the first entry in the result set, while the PBS API doesn't explicitly return the datastores in a particular order.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 18, 2025
@shamoon shamoon reopened this Apr 28, 2025
@gethomepage gethomepage unlocked this conversation Apr 28, 2025
Comment thread src/widgets/proxmoxbackupserver/component.jsx Outdated
@shamoon shamoon changed the title [Proxmox Backup Server Widget] Add support for specifying a datastore Enhancement: Add support for specifying a datastore to PBS widget Apr 28, 2025
@shamoon shamoon merged commit 4a9ca62 into gethomepage:dev Apr 28, 2025
1 check passed
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants