Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configurable assets attributes #46

Merged
merged 2 commits into from
Sep 5, 2014
Merged

Feature/configurable assets attributes #46

merged 2 commits into from
Sep 5, 2014

Conversation

rindeal
Copy link
Contributor

@rindeal rindeal commented Sep 5, 2014

Added ability to add attributes to the generated assets' html
Example

{{ assets.css({'class': ['some', 'classes']}) }} === {{ assets.css({'class': 'some classes'}) }} 
{{ assets.js(['async']) }} === {{ assets.js({'async': 'async'}) }}

@w00fz
Copy link
Member

w00fz commented Sep 5, 2014

Nice!

@rindeal
Copy link
Contributor Author

rindeal commented Sep 5, 2014

Thanks

@w00fz
Copy link
Member

w00fz commented Sep 5, 2014

Tested and looks great. Thank you.

If you feel like, would be nice if you could also add the this addition to the learn docs (can see it live here)

w00fz added a commit that referenced this pull request Sep 5, 2014
…butes

Feature/configurable assets attributes
@w00fz w00fz merged commit 481e61b into getgrav:develop Sep 5, 2014
@w00fz w00fz added this to the 0.9.2 Release milestone Sep 5, 2014
@rindeal rindeal deleted the feature/configurable-assets-attributes branch September 5, 2014 22:08
@rindeal
Copy link
Contributor Author

rindeal commented Sep 5, 2014

I'll try to find time to add it before the release, but I prefer code over text...

@rhukster
Copy link
Member

rhukster commented Sep 5, 2014

don't we all! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants