-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme inheritence not working? #1353
Comments
Ad use Grav\Common\Theme; |
I'm sure it has something to do with the hyphenated file name. I see this mentioned in the forum, but no solution is given. I didn't think I could simply rename my php file |
Well, I have removed dashes from files and folders names and any mentions in .yaml files for these themes and guess what? It really works... Huh... |
Does it really work, though? This theme doesn't have anything in the PHP file, but if it did, would it still properly inherit? No thrown errors is one thing, but that doesn't mean it's working as it should. |
Ok, sorry this took so long, should be sorted with last commit. |
@Perlkonig Yup, it worked... @rhukster That's OK, and I can confirm, that change makes my Grav installation with inherited theme work again. Thanks! |
I'm trying to follow
https://learn.getgrav.org/themes/customization#theme-inheritance
as I'm trying to enhance themeknowledge-base
with updates our company needs, but I'm getting this error:My theme files:
blueprints.yaml
:netto-knowledge-base.php
:netto-knowledge-base.yaml
:Anybody has an idea, what could be wrong? Thank you.
The text was updated successfully, but these errors were encountered: