Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase session timout #1050

Closed
Tamriel opened this issue Sep 18, 2016 · 8 comments
Closed

Increase session timout #1050

Tamriel opened this issue Sep 18, 2016 · 8 comments

Comments

@Tamriel
Copy link

Tamriel commented Sep 18, 2016

I think, one can sett the session timeout in system/config/system.yaml to a maximum of 9999.
I would like to increase that to weeks or "forever".

@rhukster
Copy link
Member

There's really no simple way to set a session timeout to 'forever' because the the session cookie needs to take a unix timestamp (date in seconds). The only real option is to make that number bigger.

We can look at increasing this available option in the admin, but in the meantime you can edit the value directly in user/config/system.yaml. For example 99999999 is over 3 years.

@rhukster
Copy link
Member

Actually the timeout has no maximum even in the admin:

   session.timeout:
                    type: text
                    size: small
                    append: NICETIME.SECOND_PLURAL
                    label: PLUGIN_ADMIN.TIMEOUT
                    help: PLUGIN_ADMIN.TIMEOUT_HELP
                    validate:
                        type: number
                        min: 1

Where are you seeing a maximum?

@Tamriel
Copy link
Author

Tamriel commented Sep 18, 2016

Interesting. I tried that with 9999999999999 and got 'Expiry date cannot have a year greater than 9999' when visiting the normal website (not the admin interface). I created this issue, because 9999 was to little for me. Using 99999999 works.

@rhukster
Copy link
Member

Ok that probably goes beyond the limit of what a computer can handle for dates.

@Tamriel
Copy link
Author

Tamriel commented Sep 19, 2016

I propose changing the error message from Expiry date cannot have a year greater than 9999 to 99999999, since 9999 is a unsatisfying maximum.

@rhukster
Copy link
Member

The error message is coming from php saying the year cannot be larger than 9999. I.e. With your 9999999999999 value the calculated expiry date is larger than 12/31/9999 which is beyond a valid date.

rhukster added a commit that referenced this issue Sep 19, 2016
@rhukster
Copy link
Member

BTW, added a quick fix to ensure that you don't go beyond the max value.

@Tamriel
Copy link
Author

Tamriel commented Sep 19, 2016

Great, thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants