Skip to content

Commit

Permalink
Bumps dependencies and corrects scopes (#87)
Browse files Browse the repository at this point in the history
Should not have runtime/compile time dependencies on Maven itself, this is provided by the container.

- Fixes getgauge/gauge#2487
- Fixes #86

Signed-off-by: Chad Wilson <[email protected]>
  • Loading branch information
chadlwilson authored Feb 15, 2024
1 parent d823953 commit 3755ee0
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 43 deletions.
18 changes: 18 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: monthly
groups:
github-actions:
patterns:
- "*"
- package-ecosystem: maven
directory: "/"
schedule:
interval: monthly
groups:
maven-dependencies:
patterns:
- "*"
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v1
- name: Set up JDK
uses: actions/setup-java@v1
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
java-version: '12.x.x'
distribution: 'temurin'
java-version: '11'

- name: Build with Maven
run: mvn test package
8 changes: 4 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ jobs:
password: '${{ secrets.maven_deploy_password }}'
passphrase: '${{ secrets.gpg_passphrase }}'
steps:
- uses: actions/checkout@v1
- name: Set up JDK
uses: actions/setup-java@v1
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
java-version: '12.x.x'
distribution: 'temurin'
java-version: '11'

- name: setup
run: |
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Add the below snippet to pom.xml
<plugin>
<groupId>com.thoughtworks.gauge.maven</groupId>
<artifactId>gauge-maven-plugin</artifactId>
<version>1.4.0</version>
<version>1.6.2</version>
</plugin>
</plugins>
</build>
Expand Down Expand Up @@ -101,7 +101,7 @@ Run gauge specs in project as a part of maven test phase by adding the below exe
<plugin>
<groupId>com.thoughtworks.gauge.maven</groupId>
<artifactId>gauge-maven-plugin</artifactId>
<version>1.6.1</version>
<version>1.6.2</version>
<executions>
<execution>
<phase>test</phase>
Expand Down Expand Up @@ -147,7 +147,7 @@ Validate gauge specs in project as a part of maven test-compile phase by adding
<plugin>
<groupId>com.thoughtworks.gauge.maven</groupId>
<artifactId>gauge-maven-plugin</artifactId>
<version>1.6.1</version>
<version>1.6.2</version>
<executions>
<execution>
<phase>test-compile</phase>
Expand Down Expand Up @@ -175,7 +175,7 @@ Add the following execution to pom.xml to run both goals:
<plugin>
<groupId>com.thoughtworks.gauge.maven</groupId>
<artifactId>gauge-maven-plugin</artifactId>
<version>1.6.1</version>
<version>1.6.2</version>
<executions>
<execution>
<id>validate</id>
Expand Down
53 changes: 22 additions & 31 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,35 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.thoughtworks.gauge.maven</groupId>
<artifactId>gauge-maven-plugin</artifactId>
<version>1.6.1</version>
<version>1.6.2</version>
<packaging>maven-plugin</packaging>
<name>Gauge Maven Plugin</name>
<url>http://github.com/getgauge/gauge-maven-plugin</url>
<url>https://github.com/getgauge-contrib/gauge-maven-plugin</url>
<description>A maven plugin to execute gauge specs in the project</description>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.version>3.8.1</maven.version>
<maven.version>3.9.6</maven.version>
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
</properties>
<dependencies>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${maven.version}</version>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.14.0</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<artifactId>maven-plugin-api</artifactId>
<version>${maven.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${maven.version}</version>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>3.11.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
Expand All @@ -42,30 +44,19 @@
<version>3.3.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>3.9.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.13.0</version>
</dependency>
</dependencies>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.0.1</version>
<version>3.3.0</version>
<executions>
<execution>
<id>attach-sources</id>
Expand All @@ -78,7 +69,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.0.1</version>
<version>3.6.3</version>
<executions>
<execution>
<id>attach-javadocs</id>
Expand All @@ -91,7 +82,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>1.6</version>
<version>3.1.0</version>
<executions>
<execution>
<id>sign-artifacts</id>
Expand All @@ -111,7 +102,7 @@
<plugin>
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>
<version>1.6.8</version>
<version>1.6.13</version>
<extensions>true</extensions>
<configuration>
<serverId>ossrh</serverId>
Expand All @@ -125,7 +116,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
<version>3.5.2</version>
<version>3.11.0</version>
<configuration>
<skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
</configuration>
Expand Down Expand Up @@ -155,20 +146,20 @@
<licenses>
<license>
<name>GNU Public License version 3.0</name>
<url>http://www.gnu.org/licenses/gpl-3.0.txt</url>
<url>https://www.gnu.org/licenses/gpl-3.0.txt</url>
</license>
</licenses>
<developers>
<developer>
<name>Gauge Team</name>
<email>[email protected]</email>
<organization>ThoughtWorks</organization>
<organizationUrl>http://thoughtworks.com/</organizationUrl>
<organizationUrl>https://thoughtworks.com/</organizationUrl>
</developer>
</developers>
<scm>
<connection>scm:git:[email protected]:getgauge/gauge-java.git</connection>
<developerConnection>scm:git:[email protected]:getgauge/gauge-java.git</developerConnection>
<url>git@github.com:getgauge/gauge-java.git</url>
<connection>scm:git:[email protected]:getgauge-contrib/gauge-maven-plugin.git</connection>
<developerConnection>scm:git:[email protected]:getgauge-contrib/gauge-maven-plugin.git</developerConnection>
<url>https://github.com/getgauge-contrib/gauge-maven-plugin</url>
</scm>
</project>

0 comments on commit 3755ee0

Please sign in to comment.