fix: make snowflake connector async #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcpro1
force-pushed
the
snowflake-async
branch
4 times, most recently
from
001e845
to
bf6907c
Compare
Make the the blocking snowflake connector `async` in the most straightforward way, which is `spawn_blocking`.
There is no need split them anymore as the snowflake connector is now compliant with Send.
abcpro1
force-pushed
the
snowflake-async
branch
from
bf6907c
to
63f8754
Compare
abcpro1
commented
Sep 14, 2023
chubei
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the the blocking snowflake connector
asyncin the most straightforward way, which is to move blocking code to a separate thread withspawn_blocking.Alternatives considered to the current snowflake client in use: