Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: read env DOZER_MASTER_SECRET for api security #1991

Merged
merged 14 commits into from
Sep 11, 2023
Merged

chore: read env DOZER_MASTER_SECRET for api security #1991

merged 14 commits into from
Sep 11, 2023

Conversation

duonganhthu43
Copy link
Contributor

@duonganhthu43 duonganhthu43 commented Sep 6, 2023 •
edited
Loading

  • preserve Api Security config in live exeperience
  • add enable_api_security indicatior in live state to know wherether API explorer should fetch token before hand
  • Include ApiExplorerService for both live and cloud experience => this one providing endpoint in order to fetch the short live token on Api Explorer
  • using DOZER_MASTER_SECRET variable as default api security config on cloud

@duonganhthu43 duonganhthu43 force-pushed the feat/default-api-token-for-deployed-application branch 2 times, most recently from 80e64e0 to 6479444 Compare September 6, 2023 13:04
@duonganhthu43 duonganhthu43 force-pushed the feat/default-api-token-for-deployed-application branch 2 times, most recently from b366432 to 808e49b Compare September 7, 2023 10:34
@duonganhthu43 duonganhthu43 marked this pull request as ready for review September 7, 2023 11:20
chubei
chubei suggested changes Sep 7, 2023
View reviewed changes
dozer-api/src/grpc/client_server.rs Outdated Show resolved Hide resolved
dozer-api/src/grpc/client_server.rs Outdated Show resolved Hide resolved
dozer-api/src/rest/mod.rs Outdated Show resolved Hide resolved
dozer-cli/src/live/state.rs Outdated Show resolved Hide resolved
@chubei
Copy link
Contributor

chubei commented Sep 7, 2023 •
edited
Loading

I don't get the purpose of implementing DOZER_MASTER_TOKEN env var.

Saw the reason in the other PR

chubei
chubei previously approved these changes Sep 7, 2023
View reviewed changes
@chubei chubei dismissed their stale review September 8, 2023 02:01

One comment is not addressed

chubei
chubei approved these changes Sep 8, 2023
View reviewed changes
dozer-cli/src/live/state.rs Show resolved Hide resolved
@duonganhthu43 duonganhthu43 force-pushed the feat/default-api-token-for-deployed-application branch from 2299db5 to 5d0eac8 Compare September 11, 2023 02:51
@duonganhthu43 duonganhthu43 force-pushed the feat/default-api-token-for-deployed-application branch from 5d0eac8 to 3db5212 Compare September 11, 2023 07:04
@duonganhthu43 duonganhthu43 added this pull request to the merge queue Sep 11, 2023
Merged via the queue into getdozer:main with commit 82bebce Sep 11, 2023
5 checks passed
@duonganhthu43 duonganhthu43 deleted the feat/default-api-token-for-deployed-application branch September 11, 2023 08:12
@chubei chubei linked an issue Sep 14, 2023 that may be closed by this pull request
Dozer Live: Api Security JWT config is not working in live version #1994
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chubei chubei chubei approved these changes

@v3g42 v3g42 Awaiting requested review from v3g42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dozer Live: Api Security JWT config is not working in live version
2 participants
@duonganhthu43 @chubei