fix: resume connectors on network errors #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcpro1
force-pushed
the
connection-retry
branch
from
3d9fa2d
to
d7c327b
Compare
chubei
reviewed
Sep 1, 2023
Resume database queries on network errors. Select queries with multiple rows resume from the last row received. CDC continues from its last position.
Similarly to the MySQL connector, select queries resume from the last row received. The CDC resumes from the position where it was stopped.
abcpro1
force-pushed
the
connection-retry
branch
4 times, most recently
from
4018e3c
to
af7cc4f
Compare
Detect network failures, reconnect, and resume.
This is not a complete solution but we should use retry infrastructure provided by the object_store crate.
abcpro1
force-pushed
the
connection-retry
branch
from
af7cc4f
to
137856f
Compare
chubei
reviewed
Sep 1, 2023
chubei
force-pushed
the
connection-retry
branch
from
56d1b76
to
611e4c0
Compare
chubei
approved these changes
Sep 1, 2023
chubei
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes MySQL, Postgres, and Kafka connectors, so far.
Covers three connectors from #1916.