Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Put live cache in temporary directory. #1906

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: Put live cache in temporary directory. #1906

merged 1 commit into from
Aug 24, 2023

Conversation

chubei
Copy link
Contributor

@chubei chubei commented Aug 24, 2023

No description provided.

@chubei chubei requested a review from v3g42 August 24, 2023 06:28
@v3g42
Copy link
Contributor

v3g42 commented Aug 24, 2023

@chubei when working with cargo run, target folder is getting included and any code change seems to affect rebuilding.
It is not a production concern but annoying while developing.
Can we do something about it as well ?

@chubei
Copy link
Contributor Author

chubei commented Aug 24, 2023

Only watch the files included in --config-path?

@v3g42
Copy link
Contributor

v3g42 commented Aug 24, 2023

do we have a config-path ? that would be perfect.

@chubei
Copy link
Contributor Author

chubei commented Aug 24, 2023

We use glob patterns for --config-path https://github.com/getdozer/dozer/blob/main/dozer-cli/src/config_helper.rs#L21 Looks like Watcher doesn't support it https://docs.rs/notify/6.1.1/notify/trait.Watcher.html#tymethod.watch.

This is not trivial. I'll revert the watcher change.

@chubei chubei changed the title fix: Watch workspace recusviely. Put live cache in temporary directory. fix: Put live cache in temporary directory. Aug 24, 2023
@v3g42 v3g42 added this pull request to the merge queue Aug 24, 2023
Merged via the queue into getdozer:main with commit 392f511 Aug 24, 2023
8 checks passed
@v3g42 v3g42 deleted the fix/live_cache branch August 24, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants