Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add merge_group trigger for e2e-test GHA workflow #1897

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add merge_group trigger for e2e-test GHA workflow #1897

merged 1 commit into from
Aug 23, 2023

Conversation

Jesse-Bakker
Copy link
Contributor

No description provided.

@chubei
Copy link
Contributor

chubei commented Aug 23, 2023

We also need to change schedule to pull_request_target as we did before?

@Jesse-Bakker
Copy link
Contributor Author

We don't want to run on pull request right?

@chubei
Copy link
Contributor

chubei commented Aug 23, 2023

But it's added to branch protection. I thought you were going to trigger it and skip it on pull_request.

We don't need pull_request_target any more.

@Jesse-Bakker
Copy link
Contributor Author

I'm not sure what happens if it's required but not triggered. Let's try it without triggering on PR and if it doesn't work, I'll trigger+skip.

@chubei chubei enabled auto-merge August 23, 2023 10:10
@chubei chubei added this pull request to the merge queue Aug 23, 2023
Merged via the queue into getdozer:main with commit 57c42c7 Aug 23, 2023
8 checks passed
@Jesse-Bakker Jesse-Bakker deleted the chore/merge-queue-e2etest branch August 25, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chubei chubei chubei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jesse-Bakker @chubei