Update from Rust 1.43 to 1.46 and improve packaging in minor ways #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, toolchains are now installed against their specific version number, so they can coexist. This is particularly useful in CI environments where different branches may be on different versions.
hamchapman
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, toolchains are now installed against their specific version number so they can coexist. This is particularly useful in CI environments where different branches may be on different versions.
The good news: The rust hacks were upstreamed so we no longer need to patch rustc, nor do we need any
-Zflags. Since the-Zflag is no longer needed, we are now building the stable channel.The bad news: There is no "good" LLVM commit to target due to a bug. Here we are targeting the 5.3-RELEASE tag, which should match Xcode 12 pretty closely, and using a patch to allow the rust compilation to proceed. See the comments in the patch for a full explanation.
I have confirmed that Rust code built with this toolchain can be included in bitcode apps, deployed to physical hardware, and rebuilt from bitcode.