fix: untrack docs/superpowers/ files that violate .gitignore - #98
Merged
Conversation
.gitignore excludes /docs/superpowers/ (local spec-driven-development planning docs, not meant to ship in the repo), but 5 files under it were committed anyway. release-plz's release-pr command refuses to run when tracked files match an active .gitignore pattern: the working directory of this project has uncommitted changes... If these files are both committed and in .gitignore, either delete them or remove them from .gitignore. Untrack them (kept on disk locally, just no longer in the index) so the .gitignore rule's intent actually holds and release-plz can run.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughThis change deletes five markdown documentation files from docs/superpowers/plans and docs/superpowers/specs directories, covering auth phase 2 rotation, CLI refactor, and ponytail L1 integration plans and design specs. No source code or functional logic is affected. Changes
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignoreexcludes/docs/superpowers/entirely, but 5 files under it (spec-driven-development planning/spec docs) were committed anyway before that rule took effect.release-plz release-pr(triggered via ci: allow manual dispatch of release-plz workflow #97's newworkflow_dispatch), which refuses to compute a version bump when tracked files match an active.gitignorepattern:git rm --cachedon the 5 offending files — kept on disk locally, just no longer tracked, consistent with the existing.gitignoreintent for the whole directory.Test plan
git statusconfirms the files are untracked but still present on diskrelease-prno longer fails on this checkSummary by CodeRabbit