ci(cla): skip CLA job for maintainer and bot PRs - #95
Conversation
The allowlist already auto-passes them, so the run is pure noise; issue_comment events still always run so contributors can sign. cla is not a required branch-protection check, so the skipped status does not block merges.
📝 WalkthroughWalkthroughA job-level ChangesCLA Job Gate
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/cla.yml (1)
22-23: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMinor: bot-detection style differs from sibling workflow.
This uses
!endsWith(login, '[bot]')whereas.github/workflows/vendored-file-warning.ymlusesuser.type != 'Bot'for the same maintainer/bot-skip pattern. Both work for standard GitHub App bot accounts, but consolidating on one convention would ease future maintenance.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/cla.yml around lines 22 - 23, The bot-skip check in the pull request condition uses a different convention than the sibling workflow, so update the maintainer/bot detection in the pull request gating logic to match the existing `user.type != 'Bot'` pattern used elsewhere. Keep the same allowlist behavior for `getappz`, and adjust the condition around the pull request user fields in the workflow expression so both workflows use a consistent bot-detection approach.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/cla.yml:
- Around line 22-23: The bot-skip check in the pull request condition uses a
different convention than the sibling workflow, so update the maintainer/bot
detection in the pull request gating logic to match the existing `user.type !=
'Bot'` pattern used elsewhere. Keep the same allowlist behavior for `getappz`,
and adjust the condition around the pull request user fields in the workflow
expression so both workflows use a consistent bot-detection approach.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 26b9f8f0-9027-426f-b5de-bb1dcf0a5a6a
📒 Files selected for processing (1)
.github/workflows/cla.yml
The CLA workflow's allowlist (
getappz,dependabot[bot],*[bot]) already auto-passes these PRs, so the job run is pure noise on every owner PR. This skips the job at theiflevel instead:pull_request_targetevents fromgetappzor*[bot]authors → job skippedissue_commentevents always run — that's how contributors signclais not a required branch-protection check, so a skipped status doesn't block mergesContributor PRs are unaffected.
Summary by CodeRabbit