Skip to content

ci(cla): skip CLA job for maintainer and bot PRs - #95

Merged
getappz merged 1 commit into
masterfrom
ci/skip-cla-owner-prs
Jul 8, 2026
Merged

ci(cla): skip CLA job for maintainer and bot PRs#95
getappz merged 1 commit into
masterfrom
ci/skip-cla-owner-prs

Conversation

@getappz

@getappz getappz commented Jul 8, 2026

Copy link
Copy Markdown
Owner

The CLA workflow's allowlist (getappz,dependabot[bot],*[bot]) already auto-passes these PRs, so the job run is pure noise on every owner PR. This skips the job at the if level instead:

  • pull_request_target events from getappz or *[bot] authors → job skipped
  • issue_comment events always run — that's how contributors sign
  • cla is not a required branch-protection check, so a skipped status doesn't block merges

Contributor PRs are unaffected.

Summary by CodeRabbit

  • Bug Fixes
    • Reduced unnecessary automated checks on maintainer and bot pull requests, resulting in less noise.
    • Preserved normal handling for contributor sign-off and standard pull request activity.

The allowlist already auto-passes them, so the run is pure noise;
issue_comment events still always run so contributors can sign.
cla is not a required branch-protection check, so the skipped status
does not block merges.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

A job-level if condition was added to the cla job in the CLA Assistant GitHub Actions workflow. The condition allows the job to run on issue_comment events and on pull request events only when the author is not the maintainer or a bot account.

Changes

CLA Job Gate

Layer / File(s) Summary
Add job-level skip condition
.github/workflows/cla.yml
Adds an if condition to the cla job that skips execution for maintainer and bot pull requests while still allowing issue_comment events.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, but it does not follow the required template or include the Summary, Test plan, and Notes for reviewers sections. Rewrite it using the template headings and add a Summary, a completed Test plan, and Notes for reviewers with risk and compatibility details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main CLA workflow change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/skip-cla-owner-prs

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/cla.yml (1)

22-23: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Minor: bot-detection style differs from sibling workflow.

This uses !endsWith(login, '[bot]') whereas .github/workflows/vendored-file-warning.yml uses user.type != 'Bot' for the same maintainer/bot-skip pattern. Both work for standard GitHub App bot accounts, but consolidating on one convention would ease future maintenance.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/cla.yml around lines 22 - 23, The bot-skip check in the
pull request condition uses a different convention than the sibling workflow, so
update the maintainer/bot detection in the pull request gating logic to match
the existing `user.type != 'Bot'` pattern used elsewhere. Keep the same
allowlist behavior for `getappz`, and adjust the condition around the pull
request user fields in the workflow expression so both workflows use a
consistent bot-detection approach.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/cla.yml:
- Around line 22-23: The bot-skip check in the pull request condition uses a
different convention than the sibling workflow, so update the maintainer/bot
detection in the pull request gating logic to match the existing `user.type !=
'Bot'` pattern used elsewhere. Keep the same allowlist behavior for `getappz`,
and adjust the condition around the pull request user fields in the workflow
expression so both workflows use a consistent bot-detection approach.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 26b9f8f0-9027-426f-b5de-bb1dcf0a5a6a

📥 Commits

Reviewing files that changed from the base of the PR and between ea88354 and d35a6ee.

📒 Files selected for processing (1)
  • .github/workflows/cla.yml

@getappz
getappz merged commit 312dc79 into master Jul 8, 2026
10 checks passed
@getappz
getappz deleted the ci/skip-cla-owner-prs branch July 8, 2026 07:23
This was referenced Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant