chore: Task 5: agentflare apps run (dir) CLI command - #612
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughAdds ChangesApps Run CLI
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This adds the apps run CLI command with focused wiring and reported passing checks; no actionable merge-blocking risk remains beyond normal review. Sequence Diagram(s)sequenceDiagram
participant CLI
participant AppManifest
participant Workflow
participant app_send_hook
participant SQLite
CLI->>AppManifest: Load App and tools manifests
CLI->>Workflow: Read declared workflow
CLI->>SQLite: Resolve configured or default database path
CLI->>app_send_hook: Execute workflow with input
app_send_hook-->>CLI: Return run ID
CLI-->>CLI: Print run ID or report failure
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description provides a detailed summary, test results, implementation notes, risk assessment, and compatibility statement. It does not use the exact template headings or checklist format, and it does not report the exact ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Add src/cli/apps.rs (AppsArgs/AppsCommand::Run/run_app) mirroring cli::workflow's pattern: loads an App's app.toml/tools.toml, wires app_send_hook as the dispatch sender, and starts the run via run_workflow_json_with_sender. Register Apps(apps::AppsArgs) in src/cli/mod.rs. Drop the now-stale #[allow(dead_code)] on app_send_hook/run_workflow_json_with_sender in src/workflow.rs since they're used by production code now, not just tests. Adds two tests: an end-to-end fixture-app run producing a run id, and a missing-app.toml error-message check. Agentflare-Agent: claude-code Agentflare-Branch: task/533-task-5-agentflare-apps-run-dir-cli-comma Agentflare-Item: 533
87ae95f to
988661a
Compare
Everything is clean. Only the three intended files are changed. Summary for the user:
Status: Task 5 complete.
src/cli/apps.rs:AppsArgs/AppsCommand::Run(RunArgs)(dir/--input/--db-path),run_app()that loads the App'sapp.toml/tools.tomlviaagentflare_apps::{load_app_manifest, load_tools_manifest}, buildscrate::workflow::app_send_hook, and starts the run viacrate::workflow::run_workflow_json_with_sender— mirrorscli::workflow::WorkflowArgs's exact shape/error-handling (ui::error+process::exit(1)).Apps(apps::AppsArgs)insrc/cli/mod.rs(module decl,Commandsvariant,run()dispatch) following the Gateway/Workflow pattern.#[allow(dead_code)]onapp_send_hookandrun_workflow_json_with_senderinsrc/workflow.rssince they're now used by production code, not just tests.e5292e7,5e949be), so no changes were needed there.Tests: added the plan's two
cli::appstests (end-to-end fixture-app run producing a run id, plus a missing-app.tomlerror-message check) — both pass. Also re-ranworkflow::(21 passed) andagent_launch::(23 passed, 1 pre-existing ignored) to confirm no regressions.cargo build,cargo clippy -- -A unsafe_code -A clippy::pedantic -D warnings, andcargo fmtare all clean.No concerns —
git statusshows only the three expected files touched (src/cli/apps.rsnew,src/cli/mod.rsandsrc/workflow.rsmodified). Not committed; let me know if you'd like it committed.Opened by
claude-codeon flared:c997d745ae66 for item #533 via agentflare.Summary by CodeRabbit
New Features
apps runcommand for executing an App workflow from the command line.Tests