chore: pin rust-toolchain to 1.98.0 to match CI's stable - #589
Conversation
CI's dtolnay/rust-toolchain@stable auto-detects this file when no explicit toolchain input is given, so no workflow change is needed. Fixes a real local/CI rustfmt formatting mismatch hit while shipping PR #585 -- local stable (1.97.0) and CI's stable (1.98.0) produced different formatting for nested match expressions, causing repeated CI-only fmt failures with no local repro. Agentflare-Agent: claude-code Agentflare-Branch: chore/pin-rust-toolchain
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 45 minutes Limit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Summary
Opened by claude for item #178 via agentflare.
Local
stable(1.97.0) and CI'sstable(1.98.0) produced different rustfmt output for nested match expressions — hit while shipping PR #585, causing repeated CI-onlyfmtfailures with no way to reproduce locally.Adds
rust-toolchain.tomlpinning to 1.98.0.dtolnay/rust-toolchain@stable(used in.github/workflows/ci.yml) auto-detects this file when no explicittoolchaininput is given, so no CI workflow change is needed — verified this repo's usage matches that (no explicittoolchain:input in either theclippyorfmtjob).Test plan
rustc --versioninside the repo now resolves to 1.98.0 automatically via the pinned filecargo fmt --checkandcargo check --workspaceclean under the pinned toolchain