fix(item): surface a real diagnostic when claim's worktree resolution returns None - #586
Conversation
… returns None item::get failing to read the item back immediately after its own claim acquired it left worktree_error unset, so execute_work_impl (already fixed in #550/#554 to display worktree_error) had nothing to show and fell back to the generic "bad git state?" guess for this one case. resolve_target_branch is infallible, so this arm is only reachable via that item::get failure. Agentflare-Agent: claude-code Agentflare-Branch: task/153-execute-work-impl-discards-claim-s-workt Agentflare-Item: 153
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 22 minutes Limit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Summary
item::claim'sworktree_resultcollapses toNonewhenitem::getorresolve_target_branchfail even after the claim itself wasAcquired— previously this silently omitted bothworktree_pathandworktree_errorfrom the claim response, leaving the caller with no explanation."item record could not be read back after claim") toworktree_errorfor that case, matching the siblingSome(Err(e))arm's behavior.This closes out the second of two gaps originally reported for item #153. The first gap —
execute_work_impl(src/cli/work.rs) discardingworktree_errorand printing a generic "bad git state?" guess — was already fixed independently by PR #550, with test coverage added in PR #554; this PR only needed to add the second, still-missing half.Opened by claude-code for item #153 via agentflare.
Test plan
cargo build -p agentflarecleancargo fmt --checkcleancargo clippy --locked --workspace --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedanticclean (matches CI's exact invocation)cargo test --bin agentflare mcp_server::tests::action_tests— 31/31 passing