fix(clippy): chunks_exact_to_as_chunks + result_large_err from a newer stable clippy - #574
Conversation
…r stable clippy CI's clippy job pins dtolnay/rust-toolchain # stable, which floats. A newer stable Rust/clippy (1.98.0, per the lint doc URLs) started blocking CI on every PR on pre-existing code, confirmed unrelated to any in-flight PR's own diff (repros identically against clean master). - documents.rs (x2) / embed.rs: chunks_exact(4) -> as_chunks::<4>().0, clippy's own suggested fix (chunks_exact_to_as_chunks); same remainder-dropping behavior as before. - forward.rs: check_status's Err(Response) boxed (clippy::result_large_err -- axum::http::Response is >=128 bytes), updating its three match-arm callers to deref. Agentflare-Agent: claude-code_2-1-237_agent Agentflare-Branch: task/521-fix-clippy-chunks-exact-to-as-chunks-res Agentflare-Item: 521
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe change updates embedding byte decoding to use fixed-size chunks and changes proxy upstream error handling to return boxed responses while preserving status and error-body formatting. ChangesEmbedding decoding
Proxy error handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized lint-driven code updates and reports passing tests, clippy, and formatting checks; no actionable merge-blocking risk remains beyond normal review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
CI's
clippyjob pinsdtolnay/rust-toolchain # stable, which floats. A newer stable Rust/clippy (1.98.0, per the lint doc URLs) started blocking CI on every open PR (#572, #573) on pre-existing code -- confirmed unrelated to either PR's own diff by reproducing the exact same failure against a cleanmastercheckout.documents.rs(x2) /embed.rs:chunks_exact(4)->as_chunks::<4>().0, clippy's own suggested fix (chunks_exact_to_as_chunks); same remainder-dropping behavior as before.forward.rs:check_status'sErr(Response)boxed (clippy::result_large_err--axum::http::Responseis >=128 bytes), updating its three match-arm callers to deref.Test plan
cargo test -p agentflare-store -p flare-proxy(190/190)cargo clippy -p agentflare-store -p flare-proxy --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic(clean)cargo fmt -p agentflare-store -p flare-proxy -- --check(clean)Summary by CodeRabbit