fix: add CREATE_NO_WINDOW to agentflare-shim's run_real to stop Windows console-flash - #477
Conversation
…y exec run_real is the shared PATH-shim passthrough every installed shim (agentflare-shim's generic cat/python/which/etc dispatch and flare-git-shim's final passthrough) funnels through on every invocation. PR #407 added CREATE_NO_WINDOW to 5 other spawn sites but missed this one, which dominates actual shim usage. Mirrors the no_console_window helper already used in flare-git-core::shell.rs. creation_flags only suppresses the auto-allocated console; .status()'s default stdio inheritance is untouched, so interactive passthrough is unaffected. Agentflare-Agent: claude-code Agentflare-Branch: task/464-windows-console-flash-agentflare-shim-s Agentflare-Item: 464
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Committed. Summary:
Change:
crates/agentflare-shim/src/lib.rs::run_realnow appliesCREATE_NO_WINDOW(0x0800_0000) viacreation_flagson Windows before spawning the real target binary, mirroring the existingno_console_windowhelper inflare-git-core::shell.rs. This is a pure addition — it only suppresses the auto-allocated console, doesn't touch.status()'s default stdio inheritance, so interactive passthrough is unchanged.Why this one matters most:
run_realis the shared exec path every installed shim (~/.agentflare/shims/*) funnels through on every single invocation — both the genericagentflare-shimbinary andflare-git-shim's final passthrough. PR #407 covered 5 other spawn sites but missed this dominant one.Verification performed:
cargo build -p agentflare-shim(debug + release) — cleancargo test -p agentflare-shim— 7/7 passcargo fmt --checkandcargo clippy -A unsafe_code -A clippy::pedantic— cleanVerification NOT performed (explicitly flagging, as the item requires): I could not do the live eyeball check (no console flash on a real shimmed invocation) or exercise the built binary end-to-end as an installed shim in this session — the sandboxed shell allowlist here blocks executing arbitrary/newly-built exe paths (both the copy step and direct invocation were rejected by the lean-ctx shell gate). The change is a one-line, well-precedented addition matching a pattern already shipped and working elsewhere in this codebase (
shell.rs), but the actual visual confirmation on Windows needs to happen from the user's own session per the item's own caveat.