Skip to content

fix: add CREATE_NO_WINDOW to agentflare-shim's run_real to stop Windows console-flash - #477

Merged
getappz merged 1 commit into
masterfrom
task/464-windows-console-flash-agentflare-shim-s
Aug 13, 2026
Merged

fix: add CREATE_NO_WINDOW to agentflare-shim's run_real to stop Windows console-flash#477
getappz merged 1 commit into
masterfrom
task/464-windows-console-flash-agentflare-shim-s

Conversation

@getappz

@getappz getappz commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Committed. Summary:

Change: crates/agentflare-shim/src/lib.rs::run_real now applies CREATE_NO_WINDOW (0x0800_0000) via creation_flags on Windows before spawning the real target binary, mirroring the existing no_console_window helper in flare-git-core::shell.rs. This is a pure addition — it only suppresses the auto-allocated console, doesn't touch .status()'s default stdio inheritance, so interactive passthrough is unchanged.

Why this one matters most: run_real is the shared exec path every installed shim (~/.agentflare/shims/*) funnels through on every single invocation — both the generic agentflare-shim binary and flare-git-shim's final passthrough. PR #407 covered 5 other spawn sites but missed this dominant one.

Verification performed:

  • cargo build -p agentflare-shim (debug + release) — clean
  • cargo test -p agentflare-shim — 7/7 pass
  • cargo fmt --check and cargo clippy -A unsafe_code -A clippy::pedantic — clean

Verification NOT performed (explicitly flagging, as the item requires): I could not do the live eyeball check (no console flash on a real shimmed invocation) or exercise the built binary end-to-end as an installed shim in this session — the sandboxed shell allowlist here blocks executing arbitrary/newly-built exe paths (both the copy step and direct invocation were rejected by the lean-ctx shell gate). The change is a one-line, well-precedented addition matching a pattern already shipped and working elsewhere in this codebase (shell.rs), but the actual visual confirmation on Windows needs to happen from the user's own session per the item's own caveat.

…y exec

run_real is the shared PATH-shim passthrough every installed shim (agentflare-shim's generic cat/python/which/etc dispatch and flare-git-shim's final passthrough) funnels through on every invocation. PR #407 added CREATE_NO_WINDOW to 5 other spawn sites but missed this one, which dominates actual shim usage.

Mirrors the no_console_window helper already used in flare-git-core::shell.rs. creation_flags only suppresses the auto-allocated console; .status()'s default stdio inheritance is untouched, so interactive passthrough is unaffected.

Agentflare-Agent: claude-code
Agentflare-Branch: task/464-windows-console-flash-agentflare-shim-s
Agentflare-Item: 464
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1585348-5350-49d3-8684-85f75ca1e4c9

📥 Commits

Reviewing files that changed from the base of the PR and between d0d5b19 and d94026f.

📒 Files selected for processing (1)
  • crates/agentflare-shim/src/lib.rs

Comment @coderabbitai help to get the list of available commands.

@getappz getappz changed the title Windows console-flash: agentflare-shim's run_real (the actual PATH-shim exec) missing CREATE_NO_WINDOW fix: add CREATE_NO_WINDOW to agentflare-shim's run_real to stop Windows console-flash Aug 13, 2026
@getappz
getappz merged commit 373a96f into master Aug 13, 2026
17 of 18 checks passed
@getappz
getappz deleted the task/464-windows-console-flash-agentflare-shim-s branch August 13, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant