Skip to content

feat(pm): PM skill pack fast-follows — single /pm command, portfolio roll-up, real health bottlenecks - #469

Closed
getappz wants to merge 3 commits into
masterfrom
feat/pm-fast-follows
Closed

feat(pm): PM skill pack fast-follows — single /pm command, portfolio roll-up, real health bottlenecks#469
getappz wants to merge 3 commits into
masterfrom
feat/pm-fast-follows

Conversation

@getappz

@getappz getappz commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary

Completes the §11 fast-follow tail of the PM skill pack (item #103 / #446):

  • Single /pm command. Consolidates the four /pm:* shims into one .claude/commands/pm.md with subcommand dispatch. Bare /pm (no args) now defaults to enabling PM mode (pm-mode skill) and running a daily kickoff — standup, intake triage, blockers, pull-next, then a morning briefing proposing dispatch actions for approval. Subcommands (standup/groom/plan/health/portfolio) stay read-only reports; mode on/mode off toggles PM mode explicitly.
  • Portfolio roll-up. New project(action="list"); the read-only item actions groom/standup/health accept an optional project override (name, case-insensitive, or UUID) — honored only by those reporting actions, every mutating action still resolves the repo-linked project. New /pm:portfolio workflow loops the override across every project in the workspace.
  • Real health bottlenecks. New item_assignment_events log (migration 0011) + assignment_events module. item::update records a transition whenever assignee_agent actually changes (covers claim() too, since claiming assigns through update). item_health now reports items handed between ≥2 distinct agents in the window instead of an always-empty placeholder, with a caveat that history starts at this migration.

Also in this PR

  • Splits two files that were already over scripts/loc-gate.sh's limits before this work touched them: crates/agentflare-backend/src/item.rsitem/mod.rs + item/tests.rs; src/mcp_server/tests/item_tests.rs → itself + item_tests_reporting.rs. Removed the now-stale allowlist entry for the old item.rs path.
  • Fixes one unrelated pre-existing Windows-only clippy warning (use super::* unused because the file's only test is #[cfg(unix)]-gated).

Test plan

  • cargo fmt --all --check
  • cargo clippy --locked --workspace --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic
  • cargo test --workspace (green; flare-git-shim's agent-vs-human detection tests have pre-existing environmental flakiness from ambient agent-detector env vars in this dev environment, documented in the test file itself — confirmed unrelated, zero changes to that crate on this branch)
  • scripts/loc-gate.sh full-repo scan: OK

Agentflare-Agent: claude-code_2-1-228_harness
Agentflare-Branch: feat/pm-fast-follows
Agentflare-Agent: claude-code_2-1-228_harness
Agentflare-Branch: feat/pm-fast-follows
Project override (name or UUID) on the read-only item groom/standup/health
actions, plus project(action=list), backs a new /pm:portfolio workflow that
rolls reports up across every project in the workspace.

Adds an item_assignment_events log (migration 0011), written by
item::update whenever assignee_agent changes (covers claim too, since claim
assigns through update). item_health now computes real bottlenecks (items
handed between agents >=2x in the window) instead of the always-empty
placeholder, with a caveat that history starts at this migration.

Splits crates/agentflare-backend/src/item.rs (over the LOC gate's frozen
limit) into item/mod.rs + item/tests.rs, and src/mcp_server/tests/item_tests.rs
(over the plain limit) into item_tests.rs + item_tests_reporting.rs.

Also fixes a pre-existing Windows-only clippy warning: an unused `use
super::*` in a unix-only test file.

Agentflare-Agent: claude-code_2-1-228_harness
Agentflare-Branch: feat/pm-fast-follows
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1ccd2b50-baaf-46d8-8360-a28d814541ed

📥 Commits

Reviewing files that changed from the base of the PR and between 8aa2da2 and 87d0d20.

📒 Files selected for processing (17)
  • .claude/commands/pm.md
  • .claude/skills/pm/SKILL.md
  • crates/agentflare-backend/src/assignment_events.rs
  • crates/agentflare-backend/src/db.rs
  • crates/agentflare-backend/src/item.rs
  • crates/agentflare-backend/src/item/mod.rs
  • crates/agentflare-backend/src/item/tests.rs
  • crates/agentflare-backend/src/lib.rs
  • crates/agentflare-backend/src/migrations/0011_item_assignment_events.sql
  • scripts/loc-gate.sh
  • src/mcp_server.rs
  • src/mcp_server/item.rs
  • src/mcp_server/tests/item_commit_failure_tests.rs
  • src/mcp_server/tests/item_tests.rs
  • src/mcp_server/tests/item_tests_reporting.rs
  • src/mcp_server/tests/mod.rs
  • src/mcp_server/types.rs

Comment @coderabbitai help to get the list of available commands.

@getappz

getappz commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #474 — rebased onto current master (master independently split item.rs into submodules since this branch was opened; #474 re-applies the assignment_events feature on top of that structure). Closing in favor of the rebased version.

@getappz getappz closed this Aug 13, 2026
@getappz
getappz deleted the feat/pm-fast-follows branch August 13, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant