Conversation
…st-only import unused off Linux Agentflare-Agent: claude-code_2-1-227_agent Agentflare-Branch: task/440 Agentflare-Item: 440
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe supervisor module now limits the ChangesPlatform compilation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
cfgbugs incrates/agentflare-jobs/src/supervisor.rs, introduced by PR #443 (65f0788), that make the workspace clippy gate fail on a clean checkout on Windows. Neither changes behavior on Linux or macOS.descendant_pids's non-Linux stub is unreachable on Windows. It was gated#[cfg(not(target_os = "linux"))], but its only caller (kill_graceful) sits inside#[cfg(unix)]. On Windows the stub compiles while its caller does not, leaving it genuinely dead code. Narrowed to#[cfg(all(unix, not(target_os = "linux")))], which is the macOS/BSD case it was actually written for.The test module's glob import is unused off Linux. That module has exactly one test and it is
#[cfg(target_os = "linux")]-gated, souse super::*;is unused on every other platform. Gated it to match.Why this is being opened now
Item #440 was filed and marked completed on 2026-08-11, but the fix never shipped: the commit only ever existed on an unpushed local branch, no PR was opened, and master still fails the gate today. It surfaced again while verifying item #435 (PR #459), where this pre-existing failure blocked a workspace-wide clippy run — I deliberately kept it out of that PR rather than folding in an unrelated fix.
Verification
Rebased onto current master (
0d552e0), so this includes #459's newly-merged resource-gate crate.cargo clippy --workspace --all-targets -- -D warnings -A unsafe_code -A clippy::pedanticnow completes clean on Windows. Before this change the same command failed with:The Linux-gated test itself is unchanged.