-
Notifications
You must be signed in to change notification settings - Fork 0
fix(work): headless dispatch prompt must forbid backgrounding verification (no resume mechanism exists) #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b6d7a8b
fix(work): forbid backgrounding verification in headless dispatch prompt
e8f4e2e
Merge branch 'master' into task/71
getappz 2e6faef
Merge branch 'master' into task/71
getappz ae45f5a
Merge branch 'master' into task/71
getappz 8de9441
Merge branch 'master' into task/71
getappz 0bc39e5
Merge branch 'master' into task/71
getappz 3f492c3
Merge branch 'master' into task/71
getappz 79e3e17
Merge branch 'master' into task/71
getappz 51e3bea
fix: update build_prompt call site for #448's new latest_handoff para…
a57a5cb
Merge branch 'master' into task/71
getappz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert the complete foreground-execution requirement.
The prompt also requires verification to run synchronously in the foreground and to wait for completion. This test does not assert either requirement. Add assertions for both phrases so the test protects the full one-shot execution contract.
Suggested assertions
assert!(prompt.contains("Never run build, test, or lint commands as a background task")); + assert!(prompt.contains("synchronously in the foreground")); + assert!(prompt.contains("wait for it to complete"));📝 Committable suggestion
🤖 Prompt for AI Agents