Conversation
…orkspace-hack cargo-hakari's workspace-hack (#399) changed agent-detector to default-features=false without re-adding process-tree explicitly, silently disabling tier-1 (parent process-tree walk) identity detection for every session. Every session now falls straight to tier-2 (generic AI_AGENT/AGENT env vars), which is fragile — any harness/job-runner setting a bare AGENT=<slot-index> collides with it. Concretely broke opencode's item claim: its job runner sets AGENT=1, which misresolved its identity to \1\ instead of \opencode\, tripping item::claim()'s assignee-freeze check.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request enables the Changesagent-detector feature and platform dependency configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
cargo hakari generate to add objc2-core-foundation and windows crate entries picked up by re-enabling agent-detector's process-tree feature.
Summary
cargo-hakariworkspace-hack (ci: run tests with nextest, add cargo-hakari workspace-hack #399, 2026-08-07) changedagent-detector = "0.2.1"toagent-detector = { version = "0.2.1", default-features = false }in bothCargo.tomlandcrates/flare-git-core/Cargo.toml, as an incidental side effect of feature unification — nobody explicitly re-addedfeatures = ["process-tree"].process-treegates tier 1 of the crate's 3-tier identity detection (parent process-tree walk), checked before tier 2 (genericAI_AGENT/AGENTenv vars). With it silently off, every session falls straight to the fragile generic-env-var tier.item::claim()on a handed-off item: its job runner setsAGENT=1, which misresolved its identity to"1"instead of"opencode", tripping the assignee-freeze check (crates/agentflare-backend/src/item.rs:672-684, PR feat(handoff): verified continuation commit, structured payload, duplicate-item reuse, assignee freeze #365).features = ["process-tree"]in both locations now that hakari makes default-features non-implicit. Workspace-wide fix — restores the strongest identity signal for every session, not opencode-specific.Filed as agentflare item #428.
Test plan
cargo build --workspace --all-features— cleancargo fmt --all -- --check— cleancargo test --workspace— 1133 passed, 1 failed (dashboard::server::tests::events_endpoint_streams_claims_and_cost_snapshot— pre-existing, unrelated, already tracked as item feat: i am just testing the workflo #409; confirmed deterministic on this machine regardless of this change)cargo clippy --locked --workspace --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic— 2 pre-existing errors incrates/agentflare-jobs/src/supervisor.rs(unused import, dead code), confirmed present on unmodified master too — unrelated to this changeSummary by CodeRabbit