feat(coaching): add pre-write YAGNI gate for Write/Edit

[getappz]

Auto-opened on item done for 019f676f-cff4-7230-9b98-e2966fa95054.

Summary by CodeRabbit

• New Features

  • Added a built-in coaching check that encourages a quick YAGNI review before writing or editing code.
  • The check uses a flare-code ladder to guide implementation decisions and does not apply to mechanical, generated, test, or fixture changes.
  • Updated default coaching guidance to include this pre-write review step.

• Tests

  • Expanded coverage to verify seeded coaching rules, including their triggers, sync targets, guidance, tiers, and enforcement settings.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The default coaching rules now include a non-enforced yagni-gate rule for Write and Edit. The core coaching description names the pre-write YAGNI check. The defaults test now covers all seeded rules and checks their triggers and sync targets.

Changes

Coaching Defaults

Layer / File(s)	Summary
Add and describe the YAGNI rule src/components.rs	DEFAULT_COACHING_RULES adds the yagni-gate rule for Write and Edit. The core-coaching description includes the pre-write YAGNI check.
Extend the coaching defaults test src/components.rs	The fresh-home coaching defaults test is renamed to cover all seeded rules. The test now checks each rule’s tool triggers and sync targets against its declared defaults.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• getappz/agentflare#335: It also changes src/components.rs in the coaching-rule area.
• getappz/agentflare#352: It also extends DEFAULT_COACHING_RULES and the coaching-defaults test logic.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description contains only an automation note and omits the required Summary, Test plan, and Notes for reviewers sections.	Add the required sections and document the change, test status, risks, edge cases, and backwards compatibility.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main change: adding a YAGNI gate for Write and Edit operations.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch task/95

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

src/components.rs (1)

1628-1644: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Assert the Write/Edit trigger and claude-code sync target.

The test checks body, tier, and enforced, but it does not check trigger or sync. A default rule can therefore seed with incorrect tool triggers or host synchronization and the test will still pass. Add assertions for these fields, or add focused assertions for yagni-gate.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components.rs` around lines 1628 - 1644, Extend
coaching_defaults_seed_all_default_rules_on_fresh_home to validate each seeded
rule’s trigger includes both Write and Edit, and its sync target is claude-code,
alongside the existing body, tier, and enforced assertions.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components.rs`:
- Around line 1628-1644: Extend
coaching_defaults_seed_all_default_rules_on_fresh_home to validate each seeded
rule’s trigger includes both Write and Edit, and its sync target is claude-code,
alongside the existing body, tier, and enforced assertions.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b688c67-2050-417a-a9e5-caf5e052de34

📥 Commits

Reviewing files that changed from the base of the PR and between ca2775e and 60bd4cc.

📒 Files selected for processing (1)

• src/components.rs