fix(flare-git-shim): reset recursion depth before exec'ing real git

[getappz]

Summary

• FLARE_GIT_SHIM_DEPTH was meant to guard against the shim resolving git back to itself, but it counted total process nesting instead — the incremented value was inherited unchanged into the real git child process (and anything it spawns), so it kept accumulating across unrelated git invocations within a single long-lived process tree.
• cargo test --workspace locally fails 8 tests that shell out to git, tripping the guard on legitimate usage; reproduces identically on origin/master, and passes fine in CI (no shim installed there).
• Fix: exec_real() clears RECURSION_ENV immediately before handing off to the real git binary, so each real-git subtree gets a fresh budget. The guard still applies to this shim's own internal git shell-outs (branch/classify/snapshot) made before that handoff, so genuine self-recursion is still caught.

Closes agentflare item #379.

Test plan

• cargo test --workspace — 866/866 passed in the main binary (previously 8 failing), no "recursion guard tripped" anywhere in the run
• cargo clippy --workspace --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic — clean
• cargo fmt --check — clean

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility when Git commands are delegated to the system Git executable.
  • Prevented stale recursion state from affecting nested or subsequent Git invocations.
  • Ensured pass-through commands, repository checks, bypass scenarios, and version queries execute reliably.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fdf94dae-cf2e-487c-938f-f508d0ff7645

📥 Commits

Reviewing files that changed from the base of the PR and between 5dab94b and 7b3f7eb.

📒 Files selected for processing (1)

• crates/flare-git-shim/src/main.rs

---

📝 Walkthrough

Walkthrough

The git shim adds an exec_real helper that removes RECURSION_ENV before executing the real git binary, then routes non-git, repository-exit, bypass, missing-subcommand, passthrough, and silent-exempt paths through it.

Changes

Real git delegation

Layer / File(s)	Summary
Centralized real-git execution and call-site updates crates/flare-git-shim/src/main.rs	Adds exec_real, which clears RECURSION_ENV before delegating, and replaces direct run_real calls across all listed handoff paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• getappz/agentflare#279: Related shim recursion-depth handling and real-git delegation logic.
• getappz/agentflare#304: Related real-git resolution behavior in the presence of shim directories.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: resetting recursion depth before handing off to real git.
Description check	✅ Passed	The summary and test plan are complete and specific; the notes for reviewers section is missing, but that's non-critical.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch task/379

---

_{Comment @coderabbitai help to get the list of available commands.}