feat: auth vault phase 3 - failover runner, profile isolation (#23) - #33
Closed
getappz wants to merge 6 commits into
Closed
feat: auth vault phase 3 - failover runner, profile isolation (#23)#33getappz wants to merge 6 commits into
getappz wants to merge 6 commits into
Conversation
SQLite-backed rotation (smart/round-robin/random), cooldown tracking, health scoring with exponential penalty decay, aliases, project associations. Refactors Auth from Agents subcommand to top-level.
Path traversal validation for agent/profile names. Extract filter_active() and select_profile() to eliminate duplication. Remove dead _agent param from smart_pick. Fix full_rotate_flow to call rotate() public API. Fix alias test to call activate() public API. Add round_robin, next, parse_target tests. Validate parse_target for empty parts.
activate: project mapping only when no explicit profile matched.
cooldown: use space-separated timestamp for SQLite datetime('now') compat.
cooldown errors: emit JSON when --json flag set.
project_set: error on current_dir failure instead of empty path.
algorithm: validate smart/round-robin/random, reject unknown values.
auth run: wrap CLI with auto-failover on rate limit (429/rate limit detection, auto-rotate, max 5 retries). auth isolate add/ls/delete: isolated HOME profiles for parallel sessions. auth exec: run command with isolated profile HOME. auth login: login flow in isolated profile, auto-backup on success. Daemon detection helpers for codex app-server (pgrep/tasklist). 4 new tests for rate limit categorization.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Add Copilot CLI (~/.copilot/auth.json) to auth catalog. All Phase 4 extras (rename, alias, project) already implemented in Phases 1-2.
Encrypt auth files on backup, decrypt on activate. Key derived via PBKDF2 (SHA-256, 100k iterations) from passphrase. Passphrase from AGENTFLARE_VAULT_PASSPHRASE env var or interactive prompt. Unencrypted fallback when no passphrase provided. 3 tests: roundtrip, wrong pw, unique nonces.
Owner
Author
|
Superseded by #34 — rebased on master after Phase 2 merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth run: wrap CLI with auto-failover on rate limit (429/rate limit detection, auto-rotate, max 5 retries).
auth isolate add/ls/delete: isolated HOME profiles for parallel sessions.
auth exec: run command with isolated profile HOME.
auth login: login flow in isolated profile, auto-backup on success.
Daemon detection helpers for codex app-server (pgrep/tasklist).
4 new tests for rate limit categorization.