Conversation
Claude doesn't spontaneously know to use mcp__flare__flare_docs -- it's a deferred MCP tool, invisible until ToolSearch'd by name. Fixes this the same way exa.md/git.md/lean-ctx.md already do: a standing rule instruction that gets loaded into every session automatically. - rule_text.rs: new FLARE_DOCS constant (matching the existing @use/@when/@fallback/@scope vocabulary), wired into rule_targets() for claude-code and opencode explicitly, picked up automatically by cursor/codex/windsurf/vscode-copilot/cline via joined(). The 12 agent variants with no researched instructions-file convention in this codebase are left on the existing "continue"-style empty fallback rather than guessing at unverified config formats. - doctor.rs + cli/doctor.rs: new top-level `agentflare doctor [--agent] [--json]` -- read-only setup/config health check, distinct from `agentflare agents doctor` (binary/version detection) and `agentflare git doctor` (worktree hygiene). Reuses get_components(host) .check() exactly as init already does, plus flags stale rule files via init::is_stale_rule (bumped to pub(crate)). Exits 1 on any violation. Also fixes two pre-existing clippy errors surfaced while running the full CI gate (--all-targets --all-features -D warnings -A unsafe_code -A clippy::pedantic) on Windows -- confirmed via git stash to pre-date this work: - daemon_autostart.rs: agentflare_binary()/daemon_home_dir() (+ their PathBuf import) are real, only called from macOS/Linux install paths, just weren't cfg-gated themselves -- Windows saw them as dead code. - agent_launch.rs: PATH_LOCK import flagged unused on Windows -- genuinely used, but only inside #[cfg(unix)] tests. Agentflare-Agent: claude-code_2-1-220_agent Agentflare-Branch: task/345 Agentflare-Item: 345
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughAdds an ChangesDoctor diagnostics and rule coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant Doctor
participant AgentRegistry
participant Components
participant Init
CLI->>Doctor: run(agent, json)
Doctor->>AgentRegistry: detect_all()
Doctor->>Components: check_host(host)
Doctor->>Init: is_stale_rule(path, current)
Doctor-->>CLI: print results and exit status
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp__flare__flare_docs— it's a deferred MCP tool, invisible untilToolSearch'd by name. Fixes this the same wayexa.md/git.md/lean-ctx.mdalready do: a standing rule instruction loaded into every session automatically.rule_text.rs: newFLARE_DOCSconstant (matches the existing@use/@when/@fallback/@scopevocabulary), wired intorule_targets()for claude-code and opencode explicitly; cursor/codex/windsurf/vscode-copilot/cline pick it up automatically viajoined(). The 12Agentvariants with no researched instructions-file convention in this codebase (gemini-cli, github-copilot-cli, aider, cody, goose, amp, kiro, antigravity, grok, kimi, openclaw, droid) are left on the existing"continue"-style empty fallback rather than guessing at 12 unverified config formats.agentflare doctor [--agent <agent>] [--json]— read-only setup/config health check, distinct fromagentflare agents doctor(binary/version detection) andagentflare git doctor(worktree hygiene, fix(backend): add LIKE fallback to item search for compound-token substrings #235). Reusesget_components(host).check()exactly asinitalready does, plus flags stale rule files viainit::is_stale_rule. Exits 1 on any violation.git stashto pre-date this work):daemon_autostart.rs'sagentflare_binary()/daemon_home_dir()weren't cfg-gated to match their macOS/Linux-only callers;agent_launch.rs'sPATH_LOCKimport wasn't gated to match its#[cfg(unix)]-only test usage.Test plan
cargo test --bin agentflare— 771 passed, 0 failedcargo clippy --bin agentflare --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic— clean (previously 2 pre-existing errors, now fixed)cargo fmt— cleandoctor --agent claude-codecorrectly reportedrules: MISSING;init --agent claude-code -ywrote exactlyflare-docs.md(left the 3 already-present rule files untouched); re-randoctor— all green, exit 0; confirmed~/.claude/rules/flare-docs.mdcontent on diskSummary by CodeRabbit
New Features
agentflare doctorcommand to check agent configuration health.Bug Fixes