Skip to content

fix(release): use plain tag ref for SLSA provenance reusable workflow - #315

Merged
getappz merged 6 commits into
masterfrom
fix/slsa-provenance-tag-ref
Jul 24, 2026
Merged

fix(release): use plain tag ref for SLSA provenance reusable workflow#315
getappz merged 6 commits into
masterfrom
fix/slsa-provenance-tag-ref

Conversation

@getappz

@getappz getappz commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Fixes SLSA provenance workflow failing because reusable workflow refs were passed as refs/tags/v0.1.0 instead of the bare tag v0.1.0.

Summary by CodeRabbit

  • Chores
    • Streamlined pull request validation by running CI on Ubuntu and Windows.
    • Continued full cross-platform CI coverage for other builds.
    • Updated release provenance generation to use the v2.1.0 workflow release.
    • Added documentation clarifying the provenance workflow reference requirements.

getappz added 4 commits July 23, 2026 22:16
The slsa-github-generator generic builder's fetch-builder step derives the
trusted builder release from the caller's own ref, and requires a ref of the
form refs/tags/vX.Y.Z -- a SHA pin fails with "Invalid ref: ... Expected ref
of the form refs/tags/vX.Y.Z". This has failed the SLSA provenance job on
every recent release (v1.4.0, v1.5.0, v1.6.0). Switch to the plain @v2.1.0
tag form, per the generator's own docs and the pattern used by HashiCorp
Packer and Google FlatBuffers.

Agentflare-Agent: claude-code_2-1-218_agent
Agentflare-Branch: fix/slsa-provenance-tag-ref
Agentflare-Agent: claude-code_2-1-218_agent
Agentflare-Branch: fix/slsa-provenance-tag-ref
…-tag-ref

Agentflare-Agent: claude-code_2-1-218_agent
Agentflare-Branch: fix/slsa-provenance-tag-ref
Agentflare-Agent: 1
Agentflare-Branch: fix/slsa-provenance-tag-ref
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e9c51d2-d7d8-4188-93c6-d8c56e482362

📥 Commits

Reviewing files that changed from the base of the PR and between 45a6b86 and efa62bb.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The CI build OS matrix now varies by event type. The release provenance job references the SLSA generator’s v2.1.0 tag and documents the required workflow ref format.

Changes

CI matrix selection

Layer / File(s) Summary
Conditional build operating systems
.github/workflows/ci.yml
Pull requests run on Ubuntu and Windows, while other events continue to run on Ubuntu, macOS, and Windows.

Release provenance workflow

Layer / File(s) Summary
SLSA generator reference
.github/workflows/release.yml
The provenance job uses the v2.1.0 generator tag and documents the tag-ref requirement and SHA failure mode.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits the required Summary, Test plan, and Notes for reviewers sections. Add the template sections: a Summary, the test plan checklist items, and Notes for reviewers covering risk areas and backwards compatibility.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: switching the SLSA provenance reusable workflow to a plain tag ref.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/slsa-provenance-tag-ref

Comment @coderabbitai help to get the list of available commands.

@getappz
getappz enabled auto-merge (squash) July 24, 2026 04:38
@getappz
getappz merged commit 2a82d49 into master Jul 24, 2026
16 checks passed
@getappz
getappz deleted the fix/slsa-provenance-tag-ref branch July 24, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant