Conversation
…e patterns Copyright/SPDX header matching was case-sensitive, so headers like "// copyright 2024" slipped through unfiltered. The SQL-style comment branch (-- ...) only recognized Copyright, not SPDX, so "-- SPDX-License-Identifier: MIT" in SQL files wasn't stripped either, unlike the // and # branches which cover both. Agentflare-Agent: claude-code_2-1-217_agent Agentflare-Branch: task/311 Agentflare-Item: 311
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesNoise Header Filtering
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while re-reviewing #293's merged
pre_filterimplementation (item #264/#311, follow-up on issue #54):// copyright 2024(lowercase) slipped through unfiltered while// Copyright 2024was correctly stripped.-- ...) only recognizedCopyright, notSPDX—-- SPDX-License-Identifier: MITin a.sqlfile wasn't stripped, unlike the//and#branches which cover both.Both fixed in the single
NOISE_PATTERNSregex: added(?i)and addedSPDXto the--alternation.Test plan
cargo test -p agentflare-flare-code sub_skills::— 18/18 pass, including 2 new tests (pre_filter_removes_sql_style_spdx_header,pre_filter_removes_lowercase_copyright_header)cargo test -p agentflare-flare-code— 50/50 passcargo fmt --all— cleancargo clippy -p agentflare-flare-code --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic— cleanNote: issue #54's remaining acceptance criterion (user-configurable/override patterns, as opposed to these built-in defaults) is still open — not attempted here, out of scope for this small fix.
Summary by CodeRabbit