fix(search): rivalsearch param name + store FTS query sanitization - #288
Conversation
…e store FTS query - search_web: rivalsearch web_search expects num_results, not max_results (#253) - search_store: sanitize query via flare_search_kit::fts_query to prevent FTS5 column-name parsing errors like 'no such column: ctx' (#254) Agentflare-Agent: 1 Agentflare-Branch: fix/search-web-store-bugs
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fts_query() returns None only when the sanitized query has no tokens (e.g. quote-only input). The unwrap_or_else fallback was resubmitting the raw, unsanitized query to FTS5 MATCH in that case, undermining the sanitization it was meant to guarantee. Return an empty result set instead. Agentflare-Agent: claude-code_2-1-216_agent Agentflare-Branch: fix/search-web-store-bugs
rivalsearch web_search rejects num_results outside 1..=20 (schema validation). An unclamped limit (e.g. the default max of 50 used elsewhere, or a caller-supplied value) failed the whole search call instead of returning a truncated result set. Agentflare-Agent: claude-code_2-1-216_agent Agentflare-Branch: fix/search-web-store-bugs
Closes #253, closes #254.
Changes
search_web (
src/mcp_server/search.rs):max_results→num_resultsin rivalsearch delegationweb_searchtool expectsnum_results, causing a validationerror every time the web arm was used
search_store (
src/mcp_server/search.rs):flare_search_kit::fts_querysanitization before passing user queryto
doc_search→ FTS5 MATCHno such column: ctxwhenquery terms happen to match FTS5 operator/column syntax
MatchMode::All(default) — same pattern asmemory/search.rsand
search_memory