-
Notifications
You must be signed in to change notification settings - Fork 0
fix(hook): resolve PreToolUse branch guard against target file's repo, not host cwd #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🔴 Critical | 🏗️ Heavy lift
Fix branch guard bypasses for missing parameters, new directories, and local files.
The current implementation has three edge cases that will silently bypass the branch guard:
"file_path"or"path"(likeMultiEditorpatch) will result intarget_repo = None, skipping the guard entirely. You should fall back to the current directory if the path cannot be extracted."file.txt"),p.parent()returns an empty path (""). Using this as a working directory for the git subprocess fails withENOENT, returningNoneand incorrectly bypassing the guard."new_dir/file.txt"), the parent directory won't exist. The git subprocess will fail, again bypassing the guard.To fix all three, separate the path extraction, walk up the ancestors to the first existing directory (mapping
""to"."), and properly fall back to the current directory when extraction fails.🐛 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents